357135 – GenTopic should generate UIEvents with comments and javadoc warning supression

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 357135 - GenTopic should generate UIEvents with comments and javadoc warning supression

Summary: GenTopic should generate UIEvents with comments and javadoc warning supression

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.2
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	4.2 M3
Assignee:	Dean Roberts
QA Contact:	Remy Suen

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	357136
	Show dependency tree

Reported:	2011-09-08 14:30 EDT by Dean Roberts
Modified:	2011-10-26 13:43 EDT (History)
CC List:	3 users (show)

See Also:

Attachments
Patch to add comments and fix copyright (2.71 KB, patch) 2011-09-13 14:10 EDT, Dean Roberts	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dean Roberts

2011-09-08 14:30:44 EDT

I've been told that UIEvents is a generated class.  The generator should probably add a comment that the class is generated.

Super deluxe would include comments with instructions on how to run the generator.

It should also generate such that it does not contain warnings.  A @SuppressWarnings("javadoc") is likely sufficient as it is not clear if the variables need any description more than just the name.

Comment 1 Paul Webster

2011-09-08 14:35:15 EDT

The app that generates that class is org.eclipse.e4.ui.internal.workbench.swt.GenTopic

PW

Comment 2 Dean Roberts

2011-09-13 14:10:34 EDT

Created attachment 203274 [details]
Patch to add comments and fix copyright

Comment 3 Remy Suen

2011-09-19 12:45:31 EDT

(In reply to comment #2)
> Created attachment 203274 [details]
> Patch to add comments and fix copyright

Can you apply this patch, Dean? It doesn't seem to work for me.

Comment 4 Remy Suen

2011-09-20 09:02:19 EDT

Fix pushed to R4_development, thanks Dean.
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_development&id=0b7cafe4c5a1c8686bb9d4492bbd70c2016939d4

Comment 5 Dean Roberts

2011-10-26 13:43:54 EDT

Verified on I20111014-1625