Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 357106 - [ui] change the order of tab folder creation
Summary: [ui] change the order of tab folder creation
Status: CLOSED FIXED
Alias: None
Product: EMFCompare
Classification: Modeling
Component: Core (show other bugs)
Version: 1.2   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: EMF Compare CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-08 11:10 EDT by Bouchet Stéphane CLA
Modified: 2012-05-22 10:13 EDT (History)
1 user (show)

See Also:

Attachments
patch (1.49 KB, patch)
2011-09-08 11:10 EDT, Bouchet Stéphane CLA 		laurent.goubet: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bouchet Stéphane CLA 2011-09-08 11:10:59 EDT 
Created attachment 203004 [details]
patch

Hi,

in order to be able to change the order of the displayed tabs, could emf compare ui changes its way its creates its tab folders ? 

attached is the patch that provides a nice way to integrates tabs.
Comment 1 Laurent Goubet CLA 2011-09-09 09:05:52 EDT 
A fix similar to the provided patch has been contributed on master and will be available in 1.3.

Basically, instead of moving the tab folder creation out of the "createContents" method as the patch suggested, we have added a new "createTabFolder" protected method which can be overriden for the purpose of ordering the tabs.
Comment 2 Bouchet Stéphane CLA 2011-09-14 05:36:26 EDT 
Hummmmm, seems that you applied the patch ( or portion of ) because looking at the master branch of emfcompare, the line 

tabFolder = new CTabFolder(composite, SWT.BOTTOM);

is still inside the constructor.

git blame give me : 

2011-08-18 [353612] patching to simplify the integration of new tabs in the compare viewer ui.

see https://github.com/mbarbero/emfcompare/commit/68f964e86206d7549d3e79af90d1022889db0d1c
Comment 3 Laurent Goubet CLA 2011-09-14 07:08:20 EDT 
This overlook has now been fixed