Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 357073 - MIDataDisassemble should support modes 2 and 3 added in GDB 7.3
Summary: MIDataDisassemble should support modes 2 and 3 added in GDB 7.3
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug (show other bugs)
Version: 8.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 8.1.0   Edit
Assignee: Marc Khouzam CLA
QA Contact: Ken Ryall CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 357270
  Show dependency tree
 
Reported: 2011-09-08 08:40 EDT by Daniel Thomas CLA
Modified: 2012-02-23 11:33 EST (History)
3 users (show)

See Also:
marc.khouzam: review? (jamesblackburn+eclipse)

Attachments
Add support for modes 2 and 3 to MIDataDissassemble (3.17 KB, patch)
2011-09-08 08:41 EDT, Daniel Thomas CLA 		no flags Details | Diff
Also patch DSF (6.23 KB, patch)
2011-09-08 10:10 EDT, Daniel Thomas CLA 		marc.khouzam: iplog+
Details | Diff
Patch committed to master (12.36 KB, patch)
2011-09-12 09:39 EDT, Marc Khouzam CLA 		marc.khouzam: iplog-
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Thomas CLA 2011-09-08 08:40:20 EDT 
Build Identifier: 

In GDB 7.3 -data-disassemble MI gained support for modes 2 and 3 for dumping the instruction opcodes. MIDataDisassemble should support those modes.

I have a patch which adds support for this.


Reproducible: Always
Comment 1 Daniel Thomas CLA 2011-09-08 08:41:13 EDT 
Created attachment 202984 [details]
Add support for modes 2 and 3 to MIDataDissassemble
Comment 2 Marc Khouzam CLA 2011-09-08 09:54:55 EDT 
A similar patch would apply to DSF-GDB:
/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/MIDataDisassemble.java
Comment 3 Daniel Thomas CLA 2011-09-08 10:10:12 EDT 
Created attachment 202990 [details]
Also patch DSF

Updated patch to also cover DSF-GDB.
Comment 4 Marc Khouzam CLA 2011-09-09 13:55:32 EDT 
Can you please confirm in this bug that:
1- you have written 100% of the patch
2- you have the right to contribute the code to eclipse

Also, what copyright should we put at the top of the files?
Should be like:
"Daniel Thomas (<company>) - Added support for mode 2 and 3 (Bug 357073)"
Comment 5 Daniel Thomas CLA 2011-09-12 06:32:47 EDT 
(In reply to comment #4)
> Can you please confirm in this bug that:
> 1- you have written 100% of the patch
I wrote 100% of this patch having examined a similar work by James Blackburn.

> 2- you have the right to contribute the code to eclipse
I have confirmed that I have the right to contribute this code to eclipse.

> Also, what copyright should we put at the top of the files?
> Should be like:
> "Daniel Thomas (<company>) - Added support for mode 2 and 3 (Bug 357073)"

"Broadcom core (Broadcom) - Added support for mode 2 and 3 (Bug 357073)"
Do you want me to update the patch to contain that?
Comment 6 Daniel Thomas CLA 2011-09-12 06:50:36 EDT 
(In reply to comment #5)
> "Broadcom core (Broadcom) - Added support for mode 2 and 3 (Bug 357073)"
> Do you want me to update the patch to contain that?
BWIM:

"Broadcom Corp. - Added support for mode 2 and 3 (Bug 357073)"
Comment 7 Marc Khouzam CLA 2011-09-12 09:39:38 EDT 
Created attachment 203158 [details]
Patch committed to master

I committed this patch to master.
Comment 8 Marc Khouzam CLA 2011-09-12 09:41:50 EDT 
The patch I committed also modified the CommandFactory classes for both CDI and DSF.

James, can you review?

Thanks Daniel for the contribution.
Comment 9 CDT Genie CLA 2011-09-12 10:23:02 EDT 
*** cdt git genie on behalf of Daniel Thomas ***

    Bug 357073: MIDataDisassemble should support modes 2 and 3 added in GDB 7.3

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=6d7a8182a01e264b6726f48e9bf29e9bd774d753