Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 357068 - [implementation] TextViewer returns null for getControl() although this is not spec'd in Viewer's javadoc API
Summary: [implementation] TextViewer returns null for getControl() although this is no...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.8   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.8 M3   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-08 08:14 EDT by Remy Suen CLA
Modified: 2011-10-26 04:26 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-09-08 08:14:20 EDT 
/**
 * Returns the primary control associated with this viewer.
 *
 * @return the SWT control which displays this viewer's content
 */
public abstract Control getControl();

ComboViewer, ListViewer, TableViewer, and TreeViewer all return the control in its getControl() implementation even if the control is disposed. TextViewer does not do this and will return null. Sounds to me like it should a) not return null or b) define that it will in its javadoc.

I noticed this problem while looking at the cause behind bug 357065.
Comment 1 Markus Keller CLA 2011-09-08 08:46:11 EDT 
Has been like this since day 0.

> should a) not return null
+1

> b) define that it will [return null] in its javadoc
That would still violate the inherited contract of Viewer#getControl().

Note that we can't just remove the "fTextWidget= null;", since the class uses a lot of "if (fTextWidget == null ..." tests and ITextViewer#getTextWidget() specifies the current behavior.
Comment 2 Dani Megert CLA 2011-10-11 04:44:53 EDT 
Fixed in master: 1e4b8d7f344d37183189f29a90c66f8970a946cf
Comment 3 Dani Megert CLA 2011-10-26 04:26:43 EDT 
Verified through code inspection.