Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 357016 - ModuleCoreNature projects should respect defaultRootSource
Summary: ModuleCoreNature projects should respect defaultRootSource
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.2.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.5   Edit
Assignee: Diego Sahagun CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on: 121460 357866 365135
Blocks: 358777 360265
  Show dependency tree
 
Reported: 2011-09-07 17:41 EDT by Carl Anderson CLA
Modified: 2012-02-22 15:38 EST (History)
0 users

See Also:
cbridgha: review+

Attachments
Fix patch (21.46 KB, patch)
2011-09-07 17:52 EDT, Diego Sahagun CLA 		ccc: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carl Anderson CLA 2011-09-07 17:41:45 EDT 
Currently, if a Java EE facet is added to an existing ModuleCoreNature project, it overwrites the existing defaultRootSource with a new one, and does not take that defaultRootSource into account for the corresponding value.

We need to respect previously set defaultRootSource values.
Comment 1 Diego Sahagun CLA 2011-09-07 17:52:46 EDT 
Created attachment 202944 [details]
Fix patch

The ModelProviders are updated such that, if the project exists, is a ModuleCore project and the defaultRootSource exists, that value is used as the default instead of the product-defined default.

Also unnecessary '/' characters were removed from the InstallDelegates, which allows for the values read by the ModelProviders to be used.
Comment 2 Chuck Bridgham CLA 2011-09-12 10:08:45 EDT 
approved
Comment 3 Carl Anderson CLA 2011-09-12 15:25:43 EDT 
Committed to HEAD and R3_2_maintenance for WTP 3.4.0 and WTP 3.2.5 respectively.  Please clone this bug for WTP 3.3.2.