Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356997 - TVT/DVT3.7:TCT98: TVT_PTB: "Theme" dropdown is in English on Preferences>General>Appearance
Summary: TVT/DVT3.7:TCT98: TVT_PTB: "Theme" dropdown is in English on Preferences>Gene...
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.2.1   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 357117 (view as bug list)
Depends on: 356860
Blocks:
  Show dependency tree
 
Reported: 2011-09-07 15:30 EDT by DJ Houghton CLA
Modified: 2012-08-10 15:24 EDT (History)
15 users (show)

See Also:

Attachments
patch (4.91 KB, patch)
2011-09-08 13:26 EDT, DJ Houghton CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2011-09-07 15:30:03 EDT 
Bug cloned to track release into 4.1.2 maintenance branch. 


+++ This bug was initially created as a clone of Bug #356860 +++

<response_by> Carlos Marques at 2011.09.06.13.42.23 </response_by>
Build: 20110825-1600
Language: Brazilian Portuguese

Steps To Recreate Problem:
1.  Start Eclipse by double clicking eclipse.exe in the folder that you unzipped Eclipse (ex C:\Eclipse)
2.  Click Window on the main menu at the top.
3.  Select Preferences
4.  In the tree, select General > Appearance
5.  Verify the panel below is correctly displayed

Problem Description:
Drop-down values are in English, please see screenshot.

thanks

carlos

<response_by> David K at 2011.09.06.15.24.44 </response_by>
This article was reassigned from Category:''TVT/Testing,WSW37(IES),Inbox''.
Comment 1 DJ Houghton CLA 2011-09-08 12:58:37 EDT 
*** Bug 357117 has been marked as a duplicate of this bug. ***
Comment 2 DJ Houghton CLA 2011-09-08 13:26:29 EDT 
Created attachment 203013 [details]
patch

Here is a patch for the R41x stream.
It is released into the bug356997 branch but not into R4_1_maintenance. (waiting for R4.1.1 to be tagged)
Bundle has been tagged as r41x_v20110908-1330 so we can do a patch build.
Comment 3 Remy Suen CLA 2011-09-08 13:37:39 EDT 
(In reply to comment #2)
> It is released into the bug356997 branch but not into R4_1_maintenance.
> (waiting for R4.1.1 to be tagged)
> Bundle has been tagged as r41x_v20110908-1330 so we can do a patch build.

Thanks, DJ.

The changes to the map files in org.eclipse.e4.sdk has also been released into the bug356997 branch.
Comment 4 Eric Moffatt CLA 2011-10-11 13:48:30 EDT 
CDE Administration (whomever you are...;-). Could you check to ensure that this fix has made it into the 4.1.2 stream ? Mark it fixed if so and comment if it's not there...thanks a lot.
Comment 5 Kit Lo CLA 2011-10-11 14:31:14 EDT 
Eric, the latest "4.1 Stream Maintenance Build" from the Eclipse download page was "M20110912-1510". I think that was the final "4.1.1" build. Where can we find the "4.1.2" build to verify?
Comment 6 Eric Moffatt CLA 2011-10-18 15:02:48 EDT 
Kit, there's a new one...M20111012-2000

I think they get built on Wednesday nights (there may have been an interruption, Kim's really busy doing GIT migrations).
Comment 7 Kit Lo CLA 2011-10-20 22:29:46 EDT 
Eric, I checked the M20111019-2000 build. Looks like the patch is not applied to the 4.1.2 stream. Strings related to theme are still hard-coded in "org.eclipse.platform/plugin.xml".
Comment 8 Eric Moffatt CLA 2011-10-25 15:38:51 EDT 
Kit, I'll check this in M4 and see what happened...thanks a lot.
Comment 9 Kit Lo CLA 2012-01-12 22:48:11 EST 
Still not fixed in M20120112-0600 build.
Comment 10 Mike Wilson CLA 2012-04-17 15:56:00 EDT 
Should see if this is still happening. Please fix if so. Note the comments above appear to show this was fixed in 3.1 maintenance.
Comment 11 Curtis Windatt CLA 2012-07-31 14:50:30 EDT 
This is fixed in the current master and R4_2_maintenance branches.  It looks like DJ committed it to master in Sept 2011.

2c24538031eb637e23da261e539f7539e6b8cd3c

It was never fixed in R4_1_maintenance.

Paul, are we ok to close this or are we looking to backport to 4.1.2+
Comment 12 Paul Webster CLA 2012-08-10 15:24:40 EDT 
We won't patch it back to 4.1.2, as long as it's in 4.2.1
PW