Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356933 - integrate acquire heapdump into import wizard
Summary: integrate acquire heapdump into import wizard
Status: RESOLVED FIXED
Alias: None
Product: MAT
Classification: Tools
Component: GUI (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Andrew Johnson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-07 09:38 EDT by Benjamin Muskalla CLA
Modified: 2012-01-27 03:39 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Muskalla CLA 2011-09-07 09:38:21 EDT
Currently the Acquire heapdump action ins only available in the MAT perspective or via Ctrl+3.
I'd expect to find the same functionally in the "Import" wizard (eg. File > Import > Heapdump) or maybe even in the "New" wizard.
Comment 1 Andrew Johnson CLA 2012-01-24 09:44:46 EST
That's an interesting idea. I've done a bit of experimentation, and this should be possible.
The anonymous Wizard class needed to be made a public (static) class implementing IWorkbenchWizard with a no-argument constructor.
I think the ProviderConfigurationDialog should be a additional wizard page, not a separate dialog, but that we should normally skip it if it is set up.
The Configure button on the AcquireDialog page should go back to the ProviderConfigurationDialog.
The help in the yellow box then needs to change when the wizard pages change.

Is this more of a 'New' heap dump operation as a new heap dump is generated, or an 'Import' of a heap dump from an existing running VM?
Comment 2 Andrew Johnson CLA 2012-01-25 08:33:35 EST
I've coded an AcquireWizard and changed ProviderConfigurationDialog to ProviderConfigurationWizardPage. This comes first in the sequence, but on opening the wizard we jump to the AcquireDialog, and configure or back goes back to the ProviderConfigurationWizardPage. The help is just on the ProviderConfigurationWizardPage or the ProviderArgumentsWizardPage. If parameters are changed on the ProviderConfigurationWizardPage then the process list will be refreshed after pressing next, as that could change how jps etc. is called.
Comment 3 Andrew Johnson CLA 2012-01-25 09:04:58 EST
Which is more appropriate for heap dumps, the new, import or both wizard types?
http://wiki.eclipse.org/FAQ_How_do_I_add_my_wizard_to_the_New,_Import,_or_Export_menu_categories%3F
Comment 4 Andrew Johnson CLA 2012-01-27 03:39:45 EST
I've now delivered the changes. Please let me know if it does what you expect.