Description Knut Wannheden 2011-09-07 06:47:19 EDT

I think it would make sense if the method DefaultResourceDescriptionStrategy#isResolvedAndExternal(EObject, EObject) would also check if the target object is an non contained object. I.e. in case it is not a proxy check that it actually has an non null eResource(). It doesn't make sense to export dangling references.

This problem should actually be caught during validation, but at that point it is already too late. The reference has already been added to the builder state.

So I propose to change:

	protected boolean isResolvedAndExternal(EObject from, EObject to) {
		if (to == null)
			return false;
		if (!to.eIsProxy())
			return from.eResource() != to.eResource();

		return !getLazyURIEncoder()
				.isCrossLinkFragment(from.eResource(), ((InternalEObject) to).eProxyURI().fragment());
	}

to:

	protected boolean isResolvedAndExternal(EObject from, EObject to) {
		if (to == null)
			return false;
		if (!to.eIsProxy()) {
			if (to.eResource() == null) {
				LOG.error("Reference from " + EcoreUtil.getURI(from) + " to " + to + " cannot be exported as the target is not contained in a resource.");
				return false;
			}
			return from.eResource() != to.eResource();
		}
		return !getLazyURIEncoder()
				.isCrossLinkFragment(from.eResource(), ((InternalEObject) to).eProxyURI().fragment());
	}