Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356807 - Exporting a bundle project overwrites the manifest.
Summary: Exporting a bundle project overwrites the manifest.
Status: RESOLVED FIXED
Alias: None
Product: Virgo
Classification: RT
Component: tooling (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-06 09:07 EDT by Chris Frost CLA
Modified: 2012-02-13 20:42 EST (History)
5 users (show)

See Also:

Attachments
What's up here? (39.18 KB, image/png)
2012-01-27 21:41 EST, Miles Parker CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Frost CLA 2011-09-06 09:07:43 EDT 
See forum post http://www.eclipse.org/forums/index.php/t/238154/

When you export a bundle project as a jar file the manifest generated by Bundlor is overwritten with the default which is empty.

Steps to reproduce,

1. Download and unzip the attachment and import into Eclipse with the new Virgo Tools installed.
2. Sort out any errors but don't worry about missing dependencies, notice the manifest in /META-INF.
3. Project -> Export as Eclipse RT bundle, you get a warning about a generated manifest, the exported jar is not a valid OSGi bundle.
Comment 1 Glyn Normington CLA 2011-09-12 23:05:35 EDT 
The tooling has not been released yet, so correcting the version.
Comment 2 Miles Parker CLA 2012-01-27 20:13:24 EST 
See also: http://www.eclipse.org/forums/index.php/t/280053/

I'm going to take at least a look at this one now.
Comment 3 Miles Parker CLA 2012-01-27 21:41:04 EST 
Created attachment 210228 [details]
What's up here?

OK, this is truly weird. I -- like the second forum poster -- have created a project that is (I think) exactly the same, but the (inaptly named) project testgood doesn't export. Here's the really weird part. The icon on the package in the bad project is different form the one on the project that does export.
Comment 4 Miles Parker CLA 2012-02-13 20:30:52 EST 
Fixed in:

http://git.eclipse.org/c/virgo/org.eclipse.virgo.ide.git/commit/?id=5f6018c364768678dff68f4981d6c7feb0eccd7c

Cleaned up some exception handling as well.
Comment 5 Miles Parker CLA 2012-02-13 20:34:37 EST 
Oops, not quite. While it worked with my test case, when I went to check Alex's case, it was still broken.
Comment 6 Miles Parker CLA 2012-02-13 20:42:24 EST 
Actually, it was. The problem was that Alwex was using a Java lib I didn't have. When I used my machine's lib it worked fine.