Community
Participate
Working Groups
Build Identifier: M20110210-1200 i have existing maven projects (> 150) that reference as parent a single pom. the pom is used to provide common configuration (custom plugins, dependency redefinitions to exclude some dependencies, ...) therefore, all projects do reference the same parent pom: whether their own groupId might be the same as he parent's one or be different, it is specified. i was using previous integration of the m2e (when hosted at sonatype) and it was running fine (except for some inconsistencies in the way (transitive) dependencies were resolved). therefore i upgraded and found the current version very accurate. however, since i started "converting" projects into 'Maven project', i noticed the message "GroupId is duplicate of parent groupId" when opening the pom in the editor ... and all projects are now flagged as containing warnings. 1- i searched the web and did not find conclusive information about this issue and the reason such warning is generated (http://neo4j.org/forums/#nabble-td3217906) 2- i looked at the sources and (think) i found the code that generate the warning: org.eclipse.m2e.editor.xml.internal.MarkerLocationService in its static method checkParentMatchingGroupIdVersion (). is it possible to disable such warning in the project as it now renders very difficult to figure whether its code related or that "warning" ? Reproducible: Always Steps to Reproduce: 1. have a parent-pom artifact in your maven repository 2. create a maven project in eclipse, referencing the parent-pom artifact as parent and using the same group id as new artifact definition 3. confirm the creation the warning message appears.
I second this bug report. If there is going to be a warning for Group-Id it should be made optional... and probably off by default. I prefer to have my group-id listed in every pom to make copy-paste of the groupId+artifactId easy. That's just my preference, of course. Yet I don't find any best practices listed on any of the Maven websites to say this shouldn't be done.
Another vote for this feature. In large development efforts, it is sometimes not possible to force others to clean up the POMs that are not owned by you. It would be nice to be able to configure on a project basis the ability to ignore this warning.
(In reply to comment #2) > Another vote for this feature. > > In large development efforts, it is sometimes not possible to force others to > clean up the POMs that are not owned by you. > > It would be nice to be able to configure on a project basis the ability to > ignore this warning. Where do you plan to keep per-project configuration? Wouldn't this imply ability to change the project sources?
Both warnings, "GroupId is duplicate of parent groupId" and "Version is duplicate of parent version" are misleading. Maven doesn't warn about this situation and neither should m2e. Here is an example where the "Version is duplicate of parent version" warning is actually dangerous: After releasing a non-reactor parent, when preparing to release the children, I have to change the project/parent/version of the children to refer to the just released parent. Assuming that I had taken this warning seriously and removed the "redundant" project/version element from the child POMs, I would now have to add it again since it's now different to project/parent/version. Here is the catch: If I forget, my children will silently and coincidentally be build as non-SNAPSHOT without having been released properly. Sometimes redundancy is a good thing. Bottom line: these two validations should be removed or made optional via configuration. There are many Eclipse plugins that perform validation and have the ability to disable/enable warnings globally and per-project. M2e should be consistent with those plugins.
I'm okay with it being a global option instead of per-project. I'd even be okay with removing the warning outright, as it really doesn't make sense. Extraneous warnings only serve to detract attention away warnings that really matter.
Please provide a quality patch and review and apply it.
Created attachment 208505 [details] Removes the check altogether Attached patch removes the warning.
(In reply to comment #7) > Created attachment 208505 [details] > Removes the check altogether > > Attached patch removes the warning. No, this needs to be optional. We can discuss whether this is workspace-global or per-project configuration.
(In reply to comment #8) > No, this needs to be optional. We can discuss whether this is workspace-global > or per-project configuration. I don't know how to do that, sorry. I've spent more time on this than is worth it. I guess we'll just have to live with this annoyance.
If you don't specify groupId in your pom.xml, then the Sonar link in Jenkins won't work. Of course you could argue that it's a sonar plugin problem, but why throw a warning for something that's not a problem, but causing a problem when you fix the warning?
I too am very keen to see these warning messages disabled. Are there any plans to get that patch or something similar applied to the Indigo updates channel?
Definitely not Indigo and it's almost too late for Juno. There are no plans to accept the patch proposed in comment 7.
Igor, please provide your reasoning as to why the "version/groupId is duplicate of paren version/groupId" warnings are useful. The commenters on this issue seem to favor the removal of the warning while you have given no indication as to why *you* think it makes any sense.
(In reply to comment #12) > Definitely not Indigo and it's almost too late for Juno. There are no plans to > accept the patch proposed in comment 7. Thanks for the update Igor. Are there any plans for a facility to enable/disable warnings of the m2e plugin?
(In reply to comment #14) > (In reply to comment #12) > > Definitely not Indigo and it's almost too late for Juno. There are no plans to > > accept the patch proposed in comment 7. > > Thanks for the update Igor. Are there any plans for a facility to > enable/disable warnings of the m2e plugin? I am okay with workspace preferences to enable/disable this and other pom.xml error markers but somebody will have to provide a quality patch before anything happens.
Created attachment 215536 [details] Allows disabling of Pom Warning markers, using a workspace preferences page Igor, I hope you find this a "quality patch" and accept it for Juno. :-)
(In reply to comment #16) > Created attachment 215536 [details] > Allows disabling of Pom Warning markers, using a workspace preferences page > > Igor, I hope you find this a "quality patch" and accept it for Juno. :-) Thank you, thank you, thank you!!!
The patch overall looks reasonable and is small enough to sneak in RC1. I have couple of questions/requests before I can apply it * Do you really mean to add Sonatype copyright header to WarningsPreferencePage? Usually you put your name or name of your employer on the new files you crate and add yourself to the list of contributors in files you modify. * Can you confirm here that you : (a) wrote 100% of the code; (b) that they have the right to contribute the code to Eclipse; and (c) the file header contains the appropriate License header (see the thoroughly entertaining IP poster http://www.eclipse.org/legal/EclipseLegalProcessPoster.pdf). * Attached git-format-patch formatted patch, so the commit is properly credited to yourself in git log. I will be doing some RC1 preparation work over the coming (long) weekend, so it'd be nice if you could answer by then. Otherwise this patch will likely have to wait until after Juno...
Created attachment 215757 [details] Allows disabling of Pom Warning markers, using a workspace preferences page Hi Igor, Thanks for the explanations and suggestions (this is all new to me). I've followed your instructions on the copyright in the headers, and made a git-format-patch this time. I wrote 100% of the code in my personal time and have the right to commit the code to Eclipse. Cheers, Rob
Applied the patch, thank you. In the future, please use git-format-patch formatted patch. http://git.eclipse.org/c/m2e/m2e-core.git/
Proper commit url: http://git.eclipse.org/c/m2e/m2e-core.git/commit/?id=0fcd714ad71be4425786714ceec14b24221aef13
Moved to https://github.com/eclipse-m2e/m2e-core/issues/
