Community
Participate
Working Groups
The test org.eclipse.emf.facet.widgets.nattable.tests.Bug344413Test.testBug344413 fails on the build: - https://hudson.eclipse.org/hudson/job/emffacet-nightly/416/ - https://hudson.eclipse.org/hudson/job/emffacet-nightly-maintenance/11/ == trunk modifications == Modification 813 by nbros: Bug 356564 - [Table Editor] customizations on attributes and references don't work The file was modified /trunk/plugins/org.eclipse.emf.facet.widgets.nattable/src/org/eclipse/emf/facet/widgets/nattable/internal/painter/CustomizedCellPainter.java Modification 812 by nbros: Bug 355953 - Unable to create view from model element The file was added /trunk/tests/org.eclipse.emf.facet.widgets.nattable.tests/resources/Bug355953.uml The file was added /trunk/tests/org.eclipse.emf.facet.widgets.nattable.tests/src/org/eclipse/emf/facet/widgets/nattable/tests/swtbot/Bug355953Test.java The file was added /trunk/tests/org.eclipse.emf.facet.widgets.nattable.tests/src/org/eclipse/emf/facet/widgets/nattable/tests/internal/TableTestUtils.java The file was modified /trunk/plugins/org.eclipse.emf.facet.widgets.nattable/src/org/eclipse/emf/facet/widgets/nattable/internal/NatTableWidget.java The file was modified /trunk/tests/org.eclipse.emf.facet.widgets.nattable.tests/src/org/eclipse/emf/facet/widgets/nattable/tests/AllUITests.java == branch modifications == Modification 811 by nbros: Bug 355953 - Unable to create view from model element The file was added /branches/0_1/tests/org.eclipse.emf.facet.widgets.nattable.tests/src/org/eclipse/emf/facet/widgets/nattable/tests/swtbot/Bug355953Test.java The file was added /branches/0_1/tests/org.eclipse.emf.facet.widgets.nattable.tests/resources/Bug355953.uml The file was modified /branches/0_1/tests/org.eclipse.emf.facet.widgets.nattable.tests/src/org/eclipse/emf/facet/widgets/nattable/tests/AllUITests.java The file was added /branches/0_1/tests/org.eclipse.emf.facet.widgets.nattable.tests/src/org/eclipse/emf/facet/widgets/nattable/tests/internal/TableTestUtils.java The file was modified /branches/0_1/plugins/org.eclipse.emf.facet.widgets.nattable/src/org/eclipse/emf/facet/widgets/nattable/internal/NatTableWidget.java Modification 810 by nbros: Bug 356564 - [Table Editor] customizations on attributes and references don't work The file was modified /branches/0_1/plugins/org.eclipse.emf.facet.widgets.nattable/src/org/eclipse/emf/facet/widgets/nattable/internal/painter/CustomizedCellPainter.java
Created attachment 202802 [details] patch Here is a patch that fixes the regression introduced by the fix for Bug 355953.
Comment on attachment 202802 [details] patch Only for the branch 0.1. In the trunk a better patch is expected (without a return in the middle of the method.)
Comment on attachment 202802 [details] patch I've committed the patch on the branch 0_1. Committed revision 1252.
I've committed a fix on the trunk. This fix is different from Nicolas' patch because it contains code refactorings. Committed revision 1253. Let's wait the next build.
This test doesn't fails in : https://hudson.eclipse.org/hudson/job/emffacet-nightly-3.8/17/testReport/org.eclipse.emf.facet.widgets.nattable.tests/Bug344413Test/ https://hudson.eclipse.org/hudson/job/emffacet-nightly/lastCompletedBuild/testReport/pde.test.utils/PDETestListener$WrapperTestCase/
Can be closed.
