Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356791 - Commit viewer diff tab shows additional empty lines for Windows line endings
Summary: Commit viewer diff tab shows additional empty lines for Windows line endings
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Kevin Sawicki CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-06 06:04 EDT by Sascha Scholz CLA
Modified: 2011-09-21 19:03 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sascha Scholz CLA 2011-09-06 06:04:39 EDT 
If line endings are in Windows format (CRLF), the commit viewer shows additional empty lines in the diff tab.

Tested on Windows and Linux.
Comment 1 Kevin Sawicki CLA 2011-09-19 21:17:58 EDT 
Can you post a screenshot of this or a link to a commit that shows the behavior?
Comment 2 Sascha Scholz CLA 2011-09-20 14:11:16 EDT 
Example commit is 862a05dd760c9dc27d1231824ea00a8b5085caac from git://git.eclipse.org/gitroot/mylyn/org.eclipse.mylyn.reviews.git
Comment 3 Kevin Sawicki CLA 2011-09-20 15:52:03 EDT 
Great thanks, that made it very easy to debug, proposed fix pushed to: http://egit.eclipse.org/r/#change,4273
Comment 4 Matthias Sohn CLA 2011-09-21 19:03:07 EDT 
merged as 741a4fd2fc001e639a16b7e68773eb4154e34cc8