Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356781 - 'Pull' disabled when selecting multiple repositories in the 'Git Repositories' view
Summary: 'Pull' disabled when selecting multiple repositories in the 'Git Repositories...
Status: VERIFIED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.2-M1   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 358616
  Show dependency tree
 
Reported: 2011-09-06 05:12 EDT by Steffen Pingel CLA
Modified: 2011-10-04 06:46 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2011-09-06 05:12:30 EDT 
Steps:
1. Select multiple repositories
2. Open context menu

Push always shows as disabled for me.
Comment 1 Remy Suen CLA 2011-09-06 08:43:00 EDT 
(In reply to comment #0)
> Push always shows as disabled for me.

I presume you mean 'Pull', which is what I see and what you wrote in the summary, correct?
Comment 2 Steffen Pingel CLA 2011-09-06 09:30:15 EDT 
Thanks for pointing that out. Yes, I meant "Pull".
Comment 3 Dani Megert CLA 2011-09-28 04:33:07 EDT 
'Fetch from Upstream' is also not available, see bug 349560.
Comment 4 Remy Suen CLA 2011-09-28 20:27:37 EDT 
(In reply to comment #2)
> Thanks for pointing that out. Yes, I meant "Pull".

A change set has been pushed to Gerrit for review.
http://egit.eclipse.org/r/#change,4303

(In reply to comment #3)
> 'Fetch from Upstream' is also not available, see bug 349560.

Dani, let's leave that to bug 349560.
Comment 5 Remy Suen CLA 2011-09-29 22:40:27 EDT 
Jens has merged my change set to master.
http://egit.eclipse.org/w/?p=egit.git;a=commit;h=e7cf32fbf68eeff56b31fba5cfd73f4b87a6863e

Setting target milestone to 1.1 (because we don't seem to have a 1.2).
Comment 6 Remy Suen CLA 2011-09-30 07:11:35 EDT 
Forgot to mark this as RESOLVED/FIXED yesterday.
Comment 7 Remy Suen CLA 2011-09-30 07:11:54 EDT 
(In reply to comment #5)
> Setting target milestone to 1.1 (because we don't seem to have a 1.2).

Verified with EGit 1.2.0.201109300615 on Windows XP.
Comment 8 Dani Megert CLA 2011-10-04 04:43:27 EDT 
Nice!

Can I now also get bug 349560 (Fetch from Upstream). Shouldn't be too hard now ;-)
Comment 9 Dani Megert CLA 2011-10-04 06:44:04 EDT 
Something seems to be fishy (might be related to this fix): I now get this on each start:


!ENTRY org.eclipse.ui.workbench 2 0 2011-10-04 12:42:51.660
!MESSAGE A handler conflict occurred.  This may disable some commands.
!SUBENTRY 1 org.eclipse.ui.workbench 2 0 2011-10-04 12:42:51.660
!MESSAGE Conflict for 'org.eclipse.egit.ui.team.Pull':
HandlerActivation(commandId=org.eclipse.egit.ui.team.Pull,
	handler=org.eclipse.egit.ui.internal.repository.tree.command.PullCommand,
	expression=org.eclipse.core.internal.expressions.IterateExpression@71c93206,sourcePriority=1073741824)
HandlerActivation(commandId=org.eclipse.egit.ui.team.Pull,
	handler=org.eclipse.egit.ui.internal.actions.PullFromUpstreamActionHandler,
	expression=org.eclipse.core.internal.expressions.IterateExpression@338cc288,sourcePriority=1073741824)
Comment 10 Dani Megert CLA 2011-10-04 06:46:59 EDT 
(In reply to comment #9)
> Something seems to be fishy (might be related to this fix)

File bug 359819.