Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356780 - Eclipse incorrectly reports files as changed when they are not
Summary: Eclipse incorrectly reports files as changed when they are not
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.6.2   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-06 05:12 EDT by Oyvind Harboe CLA
Modified: 2011-09-12 11:52 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oyvind Harboe CLA 2011-09-06 05:12:26 EDT 
Build Identifier: 20110218-0911

When working with git out of bands and rewriting history, the file date is not a reliable way to tell if a file changed.

Rather a hash must be calculated for the file to see if it *actually* changed.

A typical use case would be when an interactive rebase is done to move around commits. This touches the file dates, but doesn't change the files.

Reproducible: Always
Comment 1 Remy Suen CLA 2011-09-06 08:07:51 EDT 
Where is this report/warning dialog coming from?
Comment 2 Oyvind Harboe CLA 2011-09-06 08:09:44 EDT 
(In reply to comment #1)
> Where is this report/warning dialog coming from?

When you click on a text file editor, Eclipse asks you "do you want
to reload, this file has changed".
Comment 3 Markus Keller CLA 2011-09-06 10:57:56 EDT 
The file has changed on disk (at least its date did), so the dialog is expected.

You're asking for a new method to detect modifications that didn't change the file contents.

If you don't care to be notified if a file has been changed outside of the workbench, then select General > Workspace > Refresh on access.
Comment 4 Dani Megert CLA 2011-09-12 11:24:59 EDT 
The report/dialog is correct.
Comment 5 Oyvind Harboe CLA 2011-09-12 11:49:15 EDT 
(In reply to comment #4)
> The report/dialog is correct.

I claim that's a fast and loose over-simplification, *especially* since git/hg (rewrite branches, merges) are now becoming much more wide-spread.

The current behaviour was good enough 10 years ago, not so much anymore.
Comment 6 Dani Megert CLA 2011-09-12 11:52:07 EDT 
We won't change this. As mentioned before, you can enable auto-refresh on access.