Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356744 - Implement ContentProposalService for Java types
Summary: Implement ContentProposalService for Java types
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Sapphire (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Konstantin Komissarchik CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-05 12:46 EDT by Kamesh Sampath CLA
Modified: 2021-11-19 09:22 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kamesh Sampath CLA 2011-09-05 12:46:36 EDT
Providing the content proposals in the text fields that will show the proposals for java packages and classes similar to what we get in other Wizards/Editors for Java classes. 

E.g. in the plugin manifest editor overview page when want the Activator class to be specified or for any plugin extension where a Class name is the parameter

This task is the extension of BUG-354199 which provides the content proposals in text field property for PossibleValues
Comment 1 Kamesh Sampath CLA 2011-09-05 12:57:27 EDT
Copied from Bug354199 for refrence to set the context for this ticket

> Regarding the JavaTypeContentProposal – i see that the JDT 
	> TypeCompletionProcessor is implemented differently and it requires text 
	> controls work with wherein we have decoupled the usage of text control and 
	> computing just proposals by using our Framework Service Pattern . Am not sure 
	> we could reuse the code,

Ok. That's a good reason for re-use being not feasible.

	> when I meant PDE its not including PDE plugin since PDE is already implicity 
	> included when we are building the plugin(s) those classes are already in the 
	> classpath via the requirements for ManifestEditor.

PDE plugins aren't on the classpath of Sapphire runtime bundles. I think you might be confusing runtime environment with development environment. If you based your implementation on PDE, then we will have to fork the code.

	> If there are IP problems with me submitting this patch, you can take the 
	> JavaTypeProposal service and publish under your contribution.

That would be a violation of Eclipse Legal rules. The quickest and least-effort way to get any of this work merged is to split off Java type proposal portion into a separate bugzilla entry with a separate patch that builds on this one. With less code to review, we can finish this part quicker. Then we can move on to the Java type portion where I can go over the process involved when you copy code from another Eclipse project.
Comment 2 Konstantin Komissarchik CLA 2011-09-05 14:40:26 EDT
Assigned to Kamesh.
Comment 3 Konstantin Komissarchik CLA 2011-11-17 18:09:48 EST
Deferring to 0.5 release.
Comment 4 Konstantin Komissarchik CLA 2012-04-09 13:42:54 EDT
Removing release target since there hasn't been any activity here since September. Let me know if you are still interested in working on this.
Comment 5 Kamesh Sampath CLA 2012-04-10 00:19:02 EDT
No worries, since am in middle of someother work is worth removing the release target will let you know when i start back on this.

Thanks