Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356693 - Too much of the websocket implementation is exposed to the webapp
Summary: Too much of the websocket implementation is exposed to the webapp
Status: RESOLVED FIXED
Alias: None
Product: Jetty
Classification: RT
Component: server (show other bugs)
Version: 7.5.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 7.5.x   Edit
Assignee: Simone Bordet CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-04 18:55 EDT by Greg Wilkins CLA
Modified: 2011-09-22 06:12 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Wilkins CLA 2011-09-04 18:55:28 EDT 
Only API classes should be exposed.
Comment 1 Greg Wilkins CLA 2011-09-04 21:25:46 EDT 
Simone,

I have committed a fix and tested briefly with cometd.war

can you confirm and resolve this issue if all is OK.
Comment 2 Greg Wilkins CLA 2011-09-04 23:21:39 EDT 
hmmm this appears to work for a cometd.war file, but not for the mvn jetty:run in cometd-demo ????
Comment 3 Simone Bordet CLA 2011-09-05 07:48:17 EDT 
I have removed WebSocketServlet to be a non-server class, because I think it should always be loaded by the webapp classloader.

I do not see any failure with jetty:run. Can you specify what errors you get ?
Comment 4 Simone Bordet CLA 2011-09-22 06:12:24 EDT 
Exposing only org.eclipse.jetty.websocket.WebSocket and org.eclipse.jetty.websocket.WebSocketFactory as system, non-server classes works fine for both war deployment and for the Jetty Maven Plugin.