Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356674 - Improve extensibility of SapphireWizard
Summary: Improve extensibility of SapphireWizard
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Sapphire (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Konstantin Komissarchik CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-04 08:21 EDT by Nepomuk Seiler CLA
Modified: 2021-11-19 09:22 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nepomuk Seiler CLA 2011-09-04 08:21:01 EDT 
Build Identifier: 

Extending SapphireWizard is hard, because addPages and perfomFinish are declared as final. I refer to this forum thread where this problem is discussed in detail: 
http://www.eclipse.org/forums/index.php/m/722086/

Reproducible: Always
Comment 1 Konstantin Komissarchik CLA 2011-09-04 11:33:32 EDT 
I am fine with making addPages method non-final, but making performFinish non-final would not be safe due to complex threading/locking issues that would arise from overriding that method directly. Instead, I will create an overridable protected variant of performFinish that will be called from the body of the main performFinish.
Comment 2 Konstantin Komissarchik CLA 2011-09-04 11:37:26 EDT 
Enhancement implemented in 0.3.1 and 0.4 streams. Please verify.
Comment 3 Ling Hao CLA 2011-09-28 19:50:35 EDT 
Verify addPages is non-final and a protected performPostFinish method that the user can override.