356672 – Version errors in 3.3.1

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356672 - Version errors in 3.3.1

Summary: Version errors in 3.3.1

Status:	RESOLVED FIXED

Alias:	None

Product:	Java Server Faces
Classification:	WebTools
Component:	JSF Tools (show other bugs)
Version:	3.3
Hardware:	PC Windows XP

Importance:	P3 blocker (vote)
Target Milestone:	3.3.1
Assignee:	Raghunathan Srinivasan
QA Contact:

URL:
Whiteboard:	PMC_approved
Keywords:

Depends on:
Blocks:

Reported:	2011-09-03 19:20 EDT by Raghunathan Srinivasan
Modified:	2011-09-07 15:37 EDT (History)
CC List:	4 users (show)

See Also:

Flags:	david_williams: pmc_approved+ raghunathan.srinivasan: pmc_approved? (naci.dai) raghunathan.srinivasan: pmc_approved? (deboer) neil.hauge: pmc_approved+ raghunathan.srinivasan: pmc_approved? (kaloyan) raghunathan.srinivasan: pmc_approved? (cbridgha) raghunathan.srinivasan: review+

Attachments
Fix version error (3.02 KB, patch) 2011-09-03 19:23 EDT, Raghunathan Srinivasan	no flags	Details \| Diff
Patch to fix license differences (4.42 KB, patch) 2011-09-05 18:25 EDT, Raghunathan Srinivasan	no flags	Details \| Diff
Fix regression in the SDK feature (2.72 KB, patch) 2011-09-06 17:55 EDT, Raghunathan Srinivasan	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Raghunathan Srinivasan

2011-09-03 19:20:05 EDT

org.eclipse.jsf.feature
    3.3.0.v201103022146-7E7IDUF9JgLWUM6WBSgXp (current) 
    3.3.0.v201103022146-7E7IBvF9JgLWUM3U8Shak (reference) 
org.eclipse.jsf_sdk.feature
    3.3.0.v201103022146-775-84JAMHXLCOlPccOGmLmx25AKhMXVN7XCThYq (current) 
    3.3.0.v201103022146-775-84JAMFyLCOlPccODkImwY0AKhMXVN4V9Tibl (reference) 
org.eclipse.jst.webpageeditor.feature
    2.3.4.v201105111126-46AA9oB5875L5K4I77 (current) 
    2.3.4.v201105111126-468b9oB5875G5M6D4A (reference) 
org.eclipse.jst.webpageeditor_sdk.feature
    2.3.4.v201105111126-557781BDEDrJ9CB9QEMBRKKApC6986M6L5J88 (current) 
    2.3.4.v201105111126-557781BBfDrJ9CB9LEODMFoApC6986H6N7E5B (reference)

Comment 1 Raghunathan Srinivasan

2011-09-03 19:23:59 EDT

Created attachment 202712 [details]
Fix version error

Comment 2 Raghunathan Srinivasan

2011-09-03 19:39:12 EDT

I am releasing the changes to 3.3.1 in case we decide we need a build without version errors to contribute to the Indigo SR1 repository.

Comment 3 Carl Anderson

2011-09-05 15:09:27 EDT

Raghu, in each of these, the version was incremented, but the license was removed, so now we have license consistency errors in each of these features.  Can the removal of the license be reverted?

I am raising this to blocking, since these issues must be addressed before Indigo SR1.

Comment 4 Raghunathan Srinivasan

2011-09-05 17:41:32 EDT

I have made no changes that should affect the license.  The last change to the license were tracked in Bug 337656.  Any idea where should I look to see the 'difference'?

Comment 5 Raghunathan Srinivasan

2011-09-05 17:58:28 EDT

I see the difference in feature.xml between o.e.jsf.feature and o.e.jst.webpageeditro.feature. I will make the change and release. Thanks

Comment 6 Raghunathan Srinivasan

2011-09-05 18:25:57 EDT

Created attachment 202774 [details]
Patch to fix license differences

Comment 7 Raghunathan Srinivasan

2011-09-05 18:29:54 EDT

Released the changes to fix license issue as reported in http://build.eclipse.org/webtools/committers/wtp-R3.3.1-M/20110903234441/M-3.3.1-20110903234441/testResults/licenseConsistency.html

Comment 8 Raghunathan Srinivasan

2011-09-05 18:32:22 EDT

(In reply to comment #3)
> Raghu, in each of these, the version was incremented, but the license was
> removed, so now we have license consistency errors in each of these features. 
> Can the removal of the license be reverted?
> 
> I am raising this to blocking, since these issues must be addressed before
> Indigo SR1.

Per Bug 337656 ,license files were removed on favor of the 'PDE Build technique' to reference the license file.

Comment 9 Chuck Bridgham

2011-09-06 15:00:55 EDT

Hi Raghu,

I initially missed the second patch renamed, and effectively deleted the org.eclipse.jsf_sdk.feature.  Was this intentional?

 <feature
-      id="org.eclipse.jsf_sdk.feature"
+      id="org.eclipse.jsf.feature"

Comment 10 Carl Anderson

2011-09-06 15:48:10 EDT

To make things more interesting, in v 1.12 of org.eclipse.jsf_jdk.feature/feature.xml, the id was changed back to org.eclipse.jsf_jdk.feature ... but the other changes were not reverted.  Therefore, a feature that all of the aggregation relies on, org.eclipse.jsf.feature, is no longer part of WTP 3.3.1 builds.

Comment 11 Raghunathan Srinivasan

2011-09-06 16:03:14 EDT

No intention of removing the SDK feature.  Reviewing

Comment 12 Raghunathan Srinivasan

2011-09-06 17:55:52 EDT

Created attachment 202846 [details]
Fix regression in the SDK feature

Comment 13 Raghunathan Srinivasan

2011-09-06 18:00:20 EDT

Requesting PMC approval to fix the regression introduced in the attempt to fix the license issue.

Comment 14 Raghunathan Srinivasan

2011-09-07 15:37:08 EDT

Released to 3.3.1.