Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356669 - e4 workbench cannot be displayed in right-to-left mode
Summary: e4 workbench cannot be displayed in right-to-left mode
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.1   Edit
Hardware: PC Windows XP
: P3 blocker (vote)
Target Milestone: 4.1.1   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-03 13:35 EDT by Kit Lo CLA
Modified: 2011-09-06 22:44 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kit Lo CLA 2011-09-03 13:35:49 EDT 
Using 4.x builds M20110831-200 & M20110826-1525, with command line option -dir rtl, e4 workbench is not displayed in right-to-left mode.

The last 4.x build that worked was M20110817-2001.

We are blocked and cannot continue with the Bidi testing!
Comment 1 Eric Moffatt CLA 2011-09-04 14:36:46 EDT 
Please be sure that the value is 'rtl' not 'RTL'; there is a defect that I found this while looking at the code that leads to the value being case-dependent. 

I'll use this defect to fix the case dependency but perhaps this will help you get back on track.

I just tried I20110831-1030 and it appears to work with '-dir rtl'.
Comment 2 Kit Lo CLA 2011-09-04 14:47:26 EDT 
The problem did not happen in the I20110831-1030 build.

I used lowercase '-dir rtl' and it happened in the 'M-builds'.
Comment 3 Eric Moffatt CLA 2011-09-05 15:18:17 EDT 
Kit, thanks for the info...I just checked M20110826-1525 and it is indeed missing the code in E4Application that parses the option.

This must have happened when we created the R4_1_maintenance branch. I'll have to check that tomorrow though, I'm not at work today...;-).
Comment 4 Remy Suen CLA 2011-09-05 15:26:51 EDT 
(In reply to comment #3)
> This must have happened when we created the R4_1_maintenance branch. I'll have
> to check that tomorrow though, I'm not at work today...;-).

The file appears to be correct so it may be something wrong with the build.
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/bundles/org.eclipse.e4.ui.workbench.swt/src/org/eclipse/e4/ui/internal/workbench/swt/E4Application.java?h=R4_1_maintenance&id=ff80c5f88a189b4a4e96c71dc8f5738ba9625368
Comment 5 Andrew Niefer CLA 2011-09-06 10:49:43 EDT 
This is a problem with the tags in the map files.
The tagging script applies a tag to the last change to affect the bundle, the time used for the tag is based on the time that commit was applied.

The problem was when the R4_1_maintenance branch was created, all the commits on that branch where applied at nearly the same time and result in the same tag.

The fix is to retag manually, the following projects need a new tag:
org.eclipse.e4.rcp
org.eclipse.ui
org.eclipse.e4.ui.workbench.swt
org.eclipse.e4.ui.tests

I have updated the map file and will start a new build.
Comment 6 Remy Suen CLA 2011-09-06 15:06:03 EDT 
(In reply to comment #5)
> I have updated the map file and will start a new build.

M20110906-1100 seems to be working now. Thank you Andrew for fixing the build and Kit for reporting this important bug!
Comment 7 Kit Lo CLA 2011-09-06 22:44:17 EDT 
I confirmed that the problem is resolved in M20110906-1100 build. Thanks!