Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356665 - MBS Wizard page doesn't consider toolchain superclass when determining visibility
Summary: MBS Wizard page doesn't consider toolchain superclass when determining visibi...
Status: RESOLVED INVALID
Alias: None
Product: CDT
Classification: Tools
Component: cdt-build-managed (show other bugs)
Version: 8.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 8.0.2   Edit
Assignee: Marc-André Laperle CLA
QA Contact: Chris Recoskie CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-03 10:48 EDT by Marc-André Laperle CLA
Modified: 2012-06-18 18:04 EDT (History)
1 user (show)

See Also:

Attachments
MBS Wizard page toolchain superclass patch (1.74 KB, patch)
2011-09-03 11:07 EDT, Marc-André Laperle CLA 		malaperle: iplog-
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc-André Laperle CLA 2011-09-03 10:48:31 EDT 
1. Open org.eclipse.cdt.managedbuilder.ui.tests/plugin.xml, open extensions
2. Find the wizard ToolchainCWizardPage (should be the 4th one), expand to see the toolchain item
3. Change the toolchain id to one that is a superclass, say cdt.managedbuild.toolchain.gnu.mingw.base
4. Open the project wizard, select the MinGW toolchain, proceed through the wizard.
5. ToolchainCWizardPage is not shown
Comment 1 Marc-André Laperle CLA 2011-09-03 11:07:36 EDT 
Created attachment 202708 [details]
MBS Wizard page toolchain superclass patch
Comment 2 Marc-André Laperle CLA 2011-09-03 11:21:59 EDT 
Andrew, does that seem reasonable to you?
Comment 3 Andrew Gvozdev CLA 2011-09-09 16:38:38 EDT 
Currently a page of a toolchain is not shown for those who extended it. What is the way for the extenders to disable page like that to regain status quo?
I am not saying such an option needs to be implemented but could you develop an idea how to handle that if the need arises?
Comment 4 Marc-André Laperle CLA 2011-12-11 01:44:31 EST 
I can't think of a nice way for extenders to disable the page. It's not a big deal to have to specify the page for each extender anyway. At this moment I don't think the behavior should be changed.