Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356663 - Mwe2Runner.run forgets what it s doing
Summary: Mwe2Runner.run forgets what it s doing
Status: RESOLVED FIXED
Alias: None
Product: EMFT
Classification: Modeling
Component: MWE (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: M6   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-03 07:17 EDT by Ed Willink CLA
Modified: 2012-03-07 10:54 EST (History)
1 user (show)

See Also:
sven.efftinge: juno+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2011-09-03 07:17:57 EDT 
Mwe2Runner.run (line 65) is

	run(((Module) eObject).getCanonicalName(), params);

This converts the known Module into a String, so that at line 78

	Module module = findModule(moduleName);

has to do a search to discover it. This is expensive, since every MWE2 in at least the project has to be loaded and parsed to rediscover what was already known.

Partial stack trace below:

Mwe2Runner.findModule(String) line: 119	
Mwe2Runner.run(String, Map<String,String>, IWorkflowContext) line: 77	
Mwe2Runner.run(String, Map<String,String>) line: 73	
Mwe2Runner.run(URI, Map<String,String>, IWorkflowContext) line: 64	
Mwe2Runner.run(URI, Map<String,String>) line: 55	
Mwe2Launcher.run(String[]) line: 74	
Mwe2Launcher.main(String[]) line: 35
Comment 1 Sven Efftinge CLA 2012-03-07 10:54:21 EST 
pushed to master