Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356653 - No close button in a detached window's shell
Summary: No close button in a detached window's shell
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.3 RC1   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-02 20:24 EDT by Konstantin Komissarchik CLA
Modified: 2013-05-14 10:21 EDT (History)
3 users (show)

See Also:

Attachments
Screen Capture (91.00 KB, image/png)
2011-09-02 21:20 EDT, Konstantin Komissarchik CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Komissarchik CLA 2011-09-02 20:24:35 EDT 
Using Eclipse 4.2 M1...

1. Open a second workbench window.
2. Open a file in editor.
3. Try to move the opened editor between the two windows.

What I am seeing is that instead of ending up in the second window, the editor ends up in a window of its own. This window has no title or controls. I could not find any means to close it. The only that helps is restarting Eclipse.
Comment 1 Remy Suen CLA 2011-09-02 21:04:57 EDT 
(In reply to comment #0)
> What I am seeing is that instead of ending up in the second window, the editor
> ends up in a window of its own. This window has no title or controls. I could
> not find any means to close it.

Please attach a screenshot. Isn't it in a tab folder similar to a detached view in Eclipse 3.x?
Comment 2 Konstantin Komissarchik CLA 2011-09-02 21:20:36 EDT 
Created attachment 202701 [details]
Screen Capture

Comparing with 3.8, I observe the following:

1. It is possible to move an editor from one window to another in 3.x. In 4.2, the editor always turns into detached view mode. I have not been successful at moving an editor between windows.

2. In 3.8, the detached view window has the close button in the title area of the window. No close button in 4.2.

3. In both 3.8 and 4.2, clicking on the X in the tab will close the window.
Comment 3 Remy Suen CLA 2011-09-02 21:24:30 EDT 
(In reply to comment #2)
> 1. It is possible to move an editor from one window to another in 3.x. In 4.2,
> the editor always turns into detached view mode. I have not been successful at
> moving an editor between windows.

This is covered by bug 346009.

> 2. In 3.8, the detached view window has the close button in the title area of
> the window. No close button in 4.2.

We will use this bug for this problem.
Comment 4 Remy Suen CLA 2011-09-06 08:37:37 EDT 
(In reply to comment #2)
> 2. In 3.8, the detached view window has the close button in the title area of
> the window. No close button in 4.2.

Eric, can we add this back for 4.x?
Comment 5 Eric Moffatt CLA 2011-09-06 16:24:20 EDT 
I suppose so...IIRC I removed it because of comments like those on bug 78965.

While they deal mostly with ESC handling they also apply to the window as well.

Now that we can have complete sashed structures inside a DW it's even worse. What does hitting the 'x' really mean ? The only answer I can make sense of is that it means to close all the views/editors in the window as a compound operation (so that if there are multiple 'dirty' parts the user only gets one prompt...does this make sense ?
Comment 6 Eric Moffatt CLA 2013-05-09 10:07:09 EDT 
Marking to verify in RC1...
Comment 7 Dani Megert CLA 2013-05-14 10:21:30 EDT 
Marking as WORKSFORME. I can't see in this bug that any fix went in.