Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356651 - [run control] Terminate and Relaunch should always terminate the launch.
Summary: [run control] Terminate and Relaunch should always terminate the launch.
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.7   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.8 M2   Edit
Assignee: Pawel Piech CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-02 18:55 EDT by Pawel Piech CLA
Modified: 2011-09-13 15:44 EDT (History)
2 users (show)

See Also:

Attachments
Fix. (2.77 KB, patch)
2011-09-02 19:42 EDT, Pawel Piech CLA 		no flags Details | Diff
Updatd patch. (2.15 KB, patch)
2011-09-06 12:12 EDT, Pawel Piech CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Piech CLA 2011-09-02 18:55:23 EDT 
Our debugger is capable of terminating individual threads and processes within a launch.  User can exercise this capability by selecting a given thread and selecting the "terminate" action.

However the same behavior is not desired for the terminate and relaunch action.  T&L will automatically relaunch the whole launch configuration that the currently selected thread belongs to.  This is unexpected and confusing to users.

The action should be changed to act only on the launch of the given selection.
Comment 1 Pawel Piech CLA 2011-09-02 19:42:32 EDT 
Created attachment 202700 [details]
Fix.
Comment 2 Pawel Piech CLA 2011-09-02 19:44:13 EDT 
Technically this represents a slight behavior change to the Terminate&Relaunch action, though it's very small change.  Any objections to this change?
Comment 3 Michael Rennie CLA 2011-09-06 11:10:48 EDT 
The patch makes sense. Perhaps a good addition would be to ask a target for is ILaunch adapter as well as doing the instanceof check.
Comment 4 Pawel Piech CLA 2011-09-06 12:12:37 EDT 
Created attachment 202821 [details]
Updatd patch.
Comment 5 Pawel Piech CLA 2011-09-06 12:14:57 EDT 
(In reply to comment #3)
> The patch makes sense. Perhaps a good addition would be to ask a target for is
> ILaunch adapter as well as doing the instanceof check.

I wavered back and forth on whether to make this change.  DebugUIPlugin.getLaunch() will perform an instanceof check, so we can leave it at that.  Thanks, I committed the fix.
Comment 6 Michael Rennie CLA 2011-09-13 15:44:42 EDT 
verified in I20110912-2126