Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356639 - ModelElementTest tests are failing
Summary: ModelElementTest tests are failing
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.2 M4   Edit
Assignee: Eric Moffatt CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-02 16:12 EDT by Remy Suen CLA
Modified: 2011-12-08 15:06 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-09-02 16:12:06 EDT 
It seems SnippetContainer is not abstract. I believe it should be.

junit.framework.AssertionFailedError: The following concrete classes don't implement 'MApplicationElement':
* SnippetContainer

	at junit.framework.Assert.fail(Assert.java:47)
	at org.eclipse.e4.ui.tests.application.ModelElementTest.testForMApplicationInterface(ModelElementTest.java:38)

junit.framework.AssertionFailedError: The following concrete classes have a mixin as base 'MApplicationElement':
* SnippetContainer

	at junit.framework.Assert.fail(Assert.java:47)
	at org.eclipse.e4.ui.tests.application.ModelElementTest.testForOptimalBaseClass(ModelElementTest.java:73)
Comment 1 Remy Suen CLA 2011-09-02 16:12:18 EDT 
Eric, please confirm.
Comment 2 Eric Moffatt CLA 2011-11-16 13:55:47 EST 
Pushed in >20111116.

commit 7ed043e1cc641d1e64fd5aec7dda371f4505c33b

I tested to make sure that the change is backwards compatible for models that have saved perspectives...
Comment 3 Eric Moffatt CLA 2011-12-08 15:06:29 EST 
Verified in I20111205-2330.