Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356634 - Revert button label on PerspectivePreference dialog is incorrect
Summary: Revert button label on PerspectivePreference dialog is incorrect
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.2 M3   Edit
Assignee: Dean Roberts CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 339130
  Show dependency tree
 
Reported: 2011-09-02 15:51 EDT by Dean Roberts CLA
Modified: 2011-10-26 11:35 EDT (History)
2 users (show)

See Also:

Attachments
Button name change to match 3.8 (1.40 KB, patch)
2011-09-02 15:54 EDT, Dean Roberts CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Roberts CLA 2011-09-02 15:51:40 EDT 
Work done for bug 339129 to rationalize the reset/revert perspective naming, was incompletely ported to 4.x stream.

The bulk of the work, putting the checkbox on the revert dialog was moved over, but the name change for the Revert button on the preferences page was not.

Steps to reproduce

1) Open the General->Perspective Preferences dialog.
2) Note the button says "Reset" in 4.1 but "Revert" in 3.8
Comment 1 Dean Roberts CLA 2011-09-02 15:54:21 EDT 
Created attachment 202695 [details]
Button name change to match 3.8
Comment 2 Remy Suen CLA 2011-09-15 09:45:06 EDT 
(In reply to comment #1)
> Created attachment 202695 [details]
> Button name change to match 3.8

This looks good to me.
Comment 3 Remy Suen CLA 2011-09-19 11:32:03 EDT 
Fix pushed to R4_development.
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_development&id=3846e90e292d1216b8193688c6a4f320e3ddb272

Thanks for the patch, Dean!
Comment 4 Dean Roberts CLA 2011-10-26 11:35:40 EDT 
Verified on I20111025-2000