Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356613 - [breakpoints] NPE when opening thread filter page with one running and one terminated launch
Summary: [breakpoints] NPE when opening thread filter page with one running and one te...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf-gdb (show other bugs)
Version: 8.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 8.0.1   Edit
Assignee: Marc Khouzam CLA
QA Contact: Marc Khouzam CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-02 11:11 EDT by Marc Khouzam CLA
Modified: 2011-09-02 17:23 EDT (History)
3 users (show)

See Also:
marc.khouzam: review? (nobody)

Attachments
Fix to return an empty array instead of null (1.04 KB, patch)
2011-09-02 14:48 EDT, Marc Khouzam CLA 		marc.khouzam: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Khouzam CLA 2011-09-02 11:11:54 EDT 
1- start two different debug sessions
2- terminate one but leave it showing in the debug view
3- open breakpoint properties for any breakpoint and choose 'filter'
=> NPE due to the terminated launch
Comment 1 Marc Khouzam CLA 2011-09-02 14:48:53 EDT 
Created attachment 202692 [details]
Fix to return an empty array instead of null

In GdbThreadFilterEditor, I noticed that syncGetThreads() would return an empty array upon failure, while syncGetContainers() would return null.  The null was causing the NPE, so I changed it to return an empty array.

I'll commit to master and 8_0
Comment 2 Marc Khouzam CLA 2011-09-02 15:44:27 EDT 
(In reply to comment #1)
 
> I'll commit to master and 8_0

I'm having trouble accessing the repo right now.  I'll try again later on.
Comment 3 Marc Khouzam CLA 2011-09-02 16:27:54 EDT 
Committed to both branches.

Mikhail, can you review?  One-line patch.
Comment 4 CDT Genie CLA 2011-09-02 17:23:01 EDT 
*** cdt git genie on behalf of Marc Khouzam ***

    Bug 356613: NPE when opening thread filter page with one running and one terminated launch

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=d7f7e9cdac837654f4b36aad012a0be705115c2e
Comment 5 CDT Genie CLA 2011-09-02 17:23:02 EDT 
*** cdt git genie on behalf of Marc Khouzam ***

    Bug 356613: NPE when opening thread filter page with one running and one terminated launch

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=1992418e3830759e80ac0b3d377283655e9f09c3