Community
Participate
Working Groups
Build Identifier: I20110613-1736 The Toggle-Comment function in PHP does not work as expected any more. When i use (alt+shift+7)=(alt+/) or alt+shift+c - i can comment code-lines. This is a nice feature, but when i use comments to comment the sourcecode these will be uncommented. So the feature which worked in eclipse 3.0, 3.2 and 3.4 is now useless. e.g. // process tokenlist $tokenlist = array_map ( function ($item) use ($lang){ // Do some overengineered stuff, or whatever to ransform Tokens into something usefull return strtolower($item); },$tokenlist); will become after toggeling: process tokenlist // $tokenlist = array_map ( // function ($item) use ($lang){ Do some overengineered stuff, or whatever to ransform Tokens into something usefull // return strtolower($item); // },$tokenlist); but should be: // // process tokenlist // $tokenlist = array_map ( // function ($item) use ($lang){ // // Do some overengineered stuff, or whatever to ransform Tokens into something usefull // return strtolower($item); // },$tokenlist); Reproducible: Always Steps to Reproduce: 1. Write some PHP-Code with comments 2. Mark block to comment/uncomment 3. Toggle comments by using alt+shift+c
I checked, whether it worked in PDT before, but i found out, that i used PHPEclipse before using PDT, so it is my fault that i assumed that it worked in PDT before. PDT Version having this erroe is: PHP Development Tools (PDT) SDK Feature 3.0.0.v20110516-1100-77--84_23JBVgSVXO7XGJz0VLa9O I also want to correct the testcase since i gave the wrong keyboard shortcut. Wrong: Alt + Shift + C Correct: CRTL + Shift + C Anyway, toggling a block, to comment or uncomment it is a feature * which should analyse the block first ** Decide whether to comment or uncomment as a whole * and this one decision should be applied to all lines, (add more comments, or remove comments) * it must not be decided for each line * it must not uncomment indented comments * it must be seen as a single transaction, not as a set of transactions.
hi, there is no such bug before eclipse 3.7,actually this is a wtp bug,we use its comment handler to deal with toggling comment block,and now I am trying to find a way to fix it,thanks for your report.
fixed in head
Verified. Ilina Stefanova
