Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356564 - [Table Editor] customizations on attributes and references don't work
Summary: [Table Editor] customizations on attributes and references don't work
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P1 major (vote)
Target Milestone: ---   Edit
Assignee: Nicolas Bros CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-02 05:44 EDT by Nicolas Bros CLA
Modified: 2020-05-01 11:26 EDT (History)
3 users (show)

See Also:
gdupe: indigo+
Ed.Merks: pmc_approved+
gdupe: review+

Attachments
patch (2.35 KB, patch)
2011-09-05 09:48 EDT, Nicolas Bros CLA 		gdupe: iplog+
gdupe: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Bros CLA 2011-09-02 05:44:43 EDT 
I tested a uiCustom on a table editor. Customizations on attributes and references seem ignored. Customizations on metaclasses are applied both to elements of this metaclass and (some of) its attributes and references.

This is a regression since it worked in 0.1
Comment 1 Nicolas Bros CLA 2011-09-02 10:32:17 EDT 
I tested on trunk and 0_1, and the problem appears on both.
Comment 2 Nicolas Bros CLA 2011-09-05 09:48:53 EDT 
Created attachment 202757 [details]
patch

Here is a patch that fixes the customization of attributes.

As for references, at first I thought they used to be customized, but in fact only the objects they reference are customized. So there is no regression for references.
Comment 3 Gregoire Dupe CLA 2011-09-05 12:01:06 EDT 
Hello Ed,

This bug causes a loss of function (some kind a customization does not work) and this does not cause any crash. 

I know that table customization feature is used by some Papyrus users.
Do you agree to commit this path before the SR1 RC3 ?

Regards,
Gregoire
Comment 4 Nicolas Bros CLA 2011-09-06 05:09:19 EDT 
Committed on branch 0_1 in revision 810.
Comment 5 Nicolas Bros CLA 2011-09-06 05:15:50 EDT 
Committed on trunk in revision 813.
Comment 6 Gregoire Dupe CLA 2012-05-23 08:08:10 EDT 
This bug can be closed.