Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356554 - EGit must not pollute toolbars of perspectives it doesn't own
Summary: EGit must not pollute toolbars of perspectives it doesn't own
Status: VERIFIED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.2-M1   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-02 03:58 EDT by Dani Megert CLA
Modified: 2011-11-07 07:04 EST (History)
4 users (show)

See Also:

Attachments
Picture showing Java perspective out of the box (12.52 KB, image/png)
2011-09-02 04:02 EDT, Dani Megert CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-09-02 03:58:55 EDT 
1.1.0.201108281957.

EGit adds the 'Open Git Commit...' button to all perspectives. That is not friendly behavior. If every plug-in would do this, the toolbar would become unusable.

This should only be added to perspectives that EGit owns. Users can add the corresponding action set(s) to other perspectives if they desire to do so.
Comment 1 Dani Megert CLA 2011-09-02 04:02:23 EDT 
Created attachment 202656 [details]
Picture showing Java perspective out of the box
Comment 2 Steffen Pingel CLA 2011-09-02 07:44:16 EDT 
It seems like a very advanced feature to specifically open a commit since commits are linked directly from relevant places (e.g. task editor, history). Considering the clutter/value ratio I'm +1 for disabling the contribution by default.
Comment 3 Kevin Sawicki CLA 2011-09-02 15:44:43 EDT 
Steffen, isn't the Open Task contribution added to all perspectives by default?

This action is similar in my opinion, it is information available elsewhere (Search, Task List, hyperlinks in editors) yet it is still on the toolbar.
Comment 4 Steffen Pingel CLA 2011-09-02 17:05:23 EDT 
Good point. I wouldn't object to removing the toolbar icon if that is demanded.
Comment 5 Dani Megert CLA 2011-11-01 12:54:31 EDT 
http://egit.eclipse.org/r/4454 pushed for review.
Comment 6 Kevin Sawicki CLA 2011-11-03 14:17:39 EDT 
Merged as commit d8e4035759bf2177d7050f71263c4631ff7e7bf0 into master.

Thanks for the fix.
Comment 7 Dani Megert CLA 2011-11-04 03:25:23 EDT 
(In reply to comment #6)
> Merged as commit d8e4035759bf2177d7050f71263c4631ff7e7bf0 into master.
> 
> Thanks for the fix.

Thanks Kevin for guiding me through my first contributions.
Comment 8 Dani Megert CLA 2011-11-07 07:04:05 EST 
Verified in 201111061513.