Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356544 - UI (e4) projects should set project specific settings for PDE "compiler"
Summary: UI (e4) projects should set project specific settings for PDE "compiler"
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-02 02:01 EDT by David Williams CLA
Modified: 2019-11-14 03:36 EST (History)
2 users (show)

See Also:


Attachments
patch for project preference changes (1.64 KB, patch)
2011-09-02 02:46 EDT, David Williams CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2011-09-02 02:01:06 EDT
This suggestion is follow up to bug 356044. First, some PDE issues are better flagged as "errors" instead of "warnings" since it makes them easier to spot, and less likely to be accidentally re-introduced. Second, instead of workspace-wide settings, it is best to set these on a project-override bases, so that then, no matter what a user's (that is, contributor's) settings are, they will get the preference intended by the project ... not their own personal preferences.
Comment 1 David Williams CLA 2011-09-02 02:46:38 EDT
Created attachment 202654 [details]
patch for project preference changes

I picked one project, org.eclipse.e4.core.commands, to make a patch for ... but similar changes should be made to many e4 projects. Applying this patch will (should) show the src.includes errors in build.properties. While those are the errors that need to currently be fixed, I set many of the other preferences to "error" also. I'm not sure what the "ideal" PDE settings are (if there is an ideal). Any conventions used by "the platform"?
Comment 2 Remy Suen CLA 2011-09-02 08:25:21 EDT
(In reply to comment #1)
> Any conventions used by "the platform"?

I don't think there's a set standard though I see that org.eclipse.ui.workbench has some PDE preferences.
Comment 3 Lars Vogel CLA 2019-11-14 03:36:23 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.