Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356518 - Deployment is missing files
Summary: Deployment is missing files
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Yun Feng Ma CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 357162 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-09-01 15:52 EDT by Joseph Vincens CLA
Modified: 2017-02-23 14:17 EST (History)
3 users (show)

See Also:

Attachments
testcase (41.10 KB, multipart/x-zip)
2011-09-01 15:56 EDT, Joseph Vincens CLA 		no flags Details
Patch for HTML Gen (5.09 KB, patch)
2011-09-08 03:18 EDT, Yun Feng Ma CLA 		no flags Details | Diff
Patch for IRUtils (810 bytes, patch)
2011-09-08 03:27 EDT, Yun Feng Ma CLA 		no flags Details | Diff
college test app (86.46 KB, application/x-zip-compressed)
2011-09-15 10:07 EDT, Joseph Vincens CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Vincens CLA 2011-09-01 15:52:23 EDT 
I'm not sure if this is a deployment or IR dependency issue, reassign as necessary.

Deploy the attached project. Weather.egl uses org.eclipse.edt.rui.widgets.Image on line 81, but it's not included in the html so when I run it fails because org.eclipse.edt.rui.widgets.Image is undefined.
Comment 1 Joseph Vincens CLA 2011-09-01 15:56:55 EDT 
Created attachment 202636 [details]
testcase
Comment 2 Yun Feng Ma CLA 2011-09-08 03:18:06 EDT 
Created attachment 202967 [details]
Patch for HTML Gen

This is a patch for HTML Generator. Please review it. Thanks.
Comment 3 Yun Feng Ma CLA 2011-09-08 03:27:39 EDT 
Created attachment 202969 [details]
Patch for IRUtils

Hi Paul,

Here is a patch for IRUtils.java, please review it.

The patch removed the below visit method in PartsReferencedResolver:
		public boolean visit(ArrayLiteral expr) {
			expr.getType().accept(this);
			return false;
		}

Think about below case:
handler MyHander1 type RUIhandler {initialUI = [ ui ],onConstructionFunction = start, cssFile="css/MyRUI4.css", title="MyHander1"}
	
	Button button{ text = "Button1" };
	ui Box{ children = [button, new Image{}]};
	
	function start()
	end	
end

The Image is not in the dependent parts got from IRUtils.getReferencedPartsFor(part).
Comment 4 Yun Feng Ma CLA 2011-09-15 09:39:22 EDT 
All fixes are in. Resolve this. Thanks.
Comment 5 Joseph Vincens CLA 2011-09-15 10:07:40 EDT 
Created attachment 203412 [details]
college test app

I still can't display a datagrid that includes columns because the , "org/eclipse/edt/rui/widgets/DataGridColumn.js" is not included.
Comment 6 Joseph Vincens CLA 2011-09-15 10:08:52 EDT 
see previous comment and file attachment
Comment 7 Yun Feng Ma CLA 2011-09-15 23:11:18 EDT 
Hi Joe,

DataGridColumn is a basic handler, this issue is covered  by bug 357284. so resolved this bug. Thanks.
Comment 8 Yun Feng Ma CLA 2011-09-16 04:03:50 EDT 
*** Bug 357162 has been marked as a duplicate of this bug. ***
Comment 9 Joseph Vincens CLA 2011-10-03 09:17:35 EDT 
verified