Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356463 - [breakpoints] Wrong label in thread filter for programs compiled without pthreads
Summary: [breakpoints] Wrong label in thread filter for programs compiled without pthr...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf-gdb (show other bugs)
Version: 8.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 8.0.1   Edit
Assignee: Marc Khouzam CLA
QA Contact: Marc Khouzam CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-01 08:34 EDT by Marc Khouzam CLA
Modified: 2011-09-01 09:23 EDT (History)
3 users (show)

See Also:
marc.khouzam: review? (nobody)

Attachments
Patch to check for null id and add id of process (3.30 KB, patch)
2011-09-01 09:05 EDT, Marc Khouzam CLA 		marc.khouzam: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Khouzam CLA 2011-09-01 08:34:12 EDT 
In Bug 349736 comment 15, Mikhail writes:
I get "Thread[1]null" in the filter dialog because the "target-id" attribute is
"process 31286". I get the same target id for GDB 7.2 and 7.3.
This is a simple program without pthreads, with pthreads the labels are fine.
Comment 1 Marc Khouzam CLA 2011-09-01 09:05:44 EDT 
Created attachment 202603 [details]
Patch to check for null id and add id of process

This patch checks that the threadId is not null, and also adds the processId to the process line of the filter dialog.

I tested with a non-pthread program, a single thread pthread program and a multi-threaded pthread program.

I'll commit to master and 8_0
Comment 2 Marc Khouzam CLA 2011-09-01 09:14:11 EDT 
Mikhail, can you review?
Comment 3 CDT Genie CLA 2011-09-01 09:23:04 EDT 
*** cdt git genie on behalf of Marc Khouzam ***

    Bug 356463: Wrong label in thread filter for programs compiled without pthreads

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=9cf02934609bb771a4d145ebee59bbac236f9be7
Comment 4 CDT Genie CLA 2011-09-01 09:23:05 EDT 
*** cdt git genie on behalf of Marc Khouzam ***

    Bug 356463: Wrong label in thread filter for programs compiled without pthreads

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=80f8e653dde2bb5363e6dce989a26f85c0512aa4