Community
Participate
Working Groups
Determine how to add Dojo mobile to EDT * The project in cvs * The project in widget selection page * The project imported into workspace
we'll be changing the widgets from the current support for Dojo 1.5. Stay tuned!
This is being deferred until after 0.7.0 ships .
Created attachment 213060 [details] EDT Dojo mobile widgets for 0.8 See attached EDT Dojo mobile widgets (which came from Ji Yong). There are some known issues: * in the sample gallery, when DojoTabContainer is embedded in a view, the view transition may have problem. * styling is not quite right in IE - use Chrome, Safari, or Firefox instead
Created attachment 213166 [details] Update version An update response for 0.8 runtime update.
I believe the BIDI related fields should be removed from DojoBase.js in the dojo mobile project.
Here are my comments after reviewing the current code in CVS. Theresa, please review my naming suggestions: * DojoMobileIconItem - * urlString - "See examples below" in the comment? * urlString - should this be renamed to 'src' so it matchs Image.egl? * lazy - "This option works only in the sync loader mode" - how do I set this mode? * labelString - Should this be renamed to 'text' to match other widgets? * labelString - have we confirmed that innerHTML from Widget.egl works here? * DojoMobileSlider * maximum - " Should not be smaller than the maximum value" in the comment? * DojoMobileListCategory * title - have we confirmed that innerHTML from Widget.egl works here? * DojoMobileProgress * intervalTime - should this just be 'interval', or 'updateInterval'? * Is there a reason we have a 'setImage' function exposed but no 'getImage' function? Is this function necessary since the imgPath field has a @Proprety on it? * DojoMobileTab * "If icon is not specified, the iconBase parameter of the parent widget is used." - I don't see an iconBase parameter? * icon* - should this be renamed to 'imagePath*' so it matchs DojoMobileProgress? * DojoMobileTabContainer * 'selection' Fix comment to indicate that it's the currently selected tab? * Define poistion constants in DojoMobileLib (i.e. DojoLib.POSITION_TOP) * Change 'layout' to 'tabPosition' to match DojoTabContainer.egl? * The DojoTabContainer widget provides events for onTabSelected and onTabRemoved. Are these events not needed for the mobile tab container? * Is there a reason for the 'className' field? All widgets support the 'class' field already. * DojoMobileTextArea * rename 'expanding' to 'isExpandable'? * rename 'value' to 'text' to match DojoTExtArea? * Remove 'cols' and 'rows' if not supported. If supported, change to numColumns and numRows to match DojoTextArea * DojoMobileToolBarButton * transition - Should this have a VEProperty and a default value? * transition - Should the transition types be defined in DojoMobileLib? * transitionDir - Should this have a VEProperty and a default value? * transitionDir - Should the transition direction types be defined in DojoMobileLib? * icon - I assume this is supposed to be a path, so I suggest we change this to be 'imagePath' to match DojoMobileProgress and update the comment to indicate a path is expected * labelString - Should this be renamed to 'text' to match other widgets? * Is there a reason for the 'className' field? All widgets support the 'class' field already. * DojoMobileView * Is there a reason for the 'className' field? All widgets support the 'class' field already. * This source code should be 'tightned up'. There is a lot of white space * Rename 'scroll*' to 'canScroll*'? * Rename 'swappable' to 'isSwappable'? * DojoMobileOpener * Rename 'modal' to 'isModal'? * Rename 'pop' to 'show'? This is what we use in other widgets.
It does not look like the current Dojo Mobile implementation will support our Rich UI MVC framework. Do we think this is possible for the future?
Do the Dojo Mobile widgets support a theme other than Claro?
Is the value in version.txt correct for this project?
We need to add "<eglpathentry kind="con" path="org.eclipse.edt.compiler.EDT_RUNTIME"/>" to the .eglpath file. I would have checked this in, but I'm not sure if the project is currently being used by contest participants (i.e. non-.8.1 I3 users).
(In reply to comment #8) > Do the Dojo Mobile widgets support a theme other than Claro? Not sure that the theme matters on mobile, since the device type determination will use either the iPhone, Android or BlackBerry CSS. Right?
The contest participants use the exposed mobile projects locally, separate with Eclipse CVS, we will not accept this change locally. Feel free to check in, Thanks. (In reply to comment #10) > We need to add "<eglpathentry kind="con" > path="org.eclipse.edt.compiler.EDT_RUNTIME"/>" to the .eglpath file. I would > have checked this in, but I'm not sure if the project is currently being used > by contest participants (i.e. non-.8.1 I3 users).
I will remove bidi related fields from DojoBase.js, will require Jiyong's help to update in Eclipse CVS server. (In reply to comment #5) > I believe the BIDI related fields should be removed from DojoBase.js in the > dojo mobile project.
According to dojo mobile official website, will remove CSS link in includeDojo.html file, and 'dojox/mobile/deviceTheme' has been added in require list of DojoMobileBase widget, which will apply mobile device theme automatically. (In reply to comment #8) > Do the Dojo Mobile widgets support a theme other than Claro?
No. I am not sure what version should be offered in version.text, dojo version or mobile widget version? (In reply to comment #9) > Is the value in version.txt correct for this project?
Hi Brian, I think we need more discussion to decide if we should apply MVC framework in dojo mobile widgets, maybe MVC is heavy for mobile application, We can submit a bug to discuss this issue in futrue. What's your opinion? (In reply to comment #7) > It does not look like the current Dojo Mobile implementation will support our > Rich UI MVC framework. Do we think this is possible for the future?
Hi Brian, Can you help to remove 'rg.eclipse.edt.rui.dojo.mobile.0.8.1' from Eclipse CVS? That's the old archive ones. Thanks.
Created attachment 217351 [details] remove bidi & CSS link Hi Brian, I removed bidi related functions in dojobase.js, and remove css link in includeDojo.html(the reason is in above comment), If you have time, please help to review. Thanks.
I removed the content from 'org.eclipse.edt.rui.dojo.mobile.0.8.1'. It is not possible to delete these projects from CVS. When we move to GIT, we will not copy this project.
The version.txt file should contain the version of the Dojo Mobile widget set that is being included in the project or referenced remotely. See version.txt in the WebContent folder of the dojo.local and dojo.remote projects for an example.
I checked in my updates to the .eglpath.
We should decide now if we want to rename the 'org.eclipse.edt.rui.dojo.mobile' project to 'org.eclipse.edt.rui.dojo.mobile.widgets', so that it matches our other widget project naming conventions.
1. Use the same dojo source version with dojo widget, will update the version.txt 2. Prefer the project name 'org.eclipse.edt.rui.dojo.mobile.widgets' to match with the project name of dojo widget. Thanks. (In reply to comment #20) > The version.txt file should contain the version of the Dojo Mobile widget set > that is being included in the project or referenced remotely. See version.txt > in the WebContent folder of the dojo.local and dojo.remote projects for an > example. (In reply to comment #22) > We should decide now if we want to rename the 'org.eclipse.edt.rui.dojo.mobile' > project to 'org.eclipse.edt.rui.dojo.mobile.widgets', so that it matches our > other widget project naming conventions.
Hi Brian, Patch in comment 18 includes changes of includeDojo.html and dojobase.js, should be regression tested in FVT week, I would like to review and check in it firstly. I will require JiYong's help to review. Thanks. :-)
(In reply to comment #24) > Hi Brian, > > Patch in comment 18 includes changes of includeDojo.html and dojobase.js, > should be regression tested in FVT week, I would like to review and check in it > firstly. I will require JiYong's help to review. Thanks. :-) Committed
I changed the project name to org.eclipse.edt.rui.dojo.mobile.widgets in CVS. I did not delete the contents of the old project at this time. We can delete this project after .8.1 ships. All updates should go against the new project.
Lu, please open another work item to investigate MVC support in the Dojo Mobile Widgets in a future release.
Assign owner to Smyle.
Hi Brian, There are many properties keep consistent with dojo mobile official, if we need to rename them to keep same with local dojo widgets? (In reply to comment #6) > Here are my comments after reviewing the current code in CVS. Theresa, please > review my naming suggestions:
I would like Theresa to comment on the statement in comment 29 as well, but it is my understanding that we are trying to make it easy for Rich UI developers to work with either widget set, which means that the set of properties in similar widgets should be the same. It is unfortunate that Dojo chose different property names between the desktop and mobile widgets, but it creates an opportunity for us to normalize this API into something consistent.
Hi Brain, Currently edt mobile framework doesn't support user drag and drop a DojoMobileToolBarButton widget from VE. It differs with other widgets in that it can only exist in DojoMobileView's toolBar attributes rather than children attribute. So there is no VE annotations in this widget's declaration. This widget is now designed to be hidden from the pallete. With these two comments, transition - Should the transition types be defined in DojoMobileLib? transitionDir - Should the transition direction types be defined in DojoMobileLib? Lu is working on it.
Hi Brian, Add my comments between '===', and update sample widgets together. (In reply to comment #6) > Here are my comments after reviewing the current code in CVS. Theresa, please > review my naming suggestions: > > * DojoMobileIconItem - > * urlString - "See examples below" in the comment? > * urlString - should this be renamed to 'src' so it matchs Image.egl? > * lazy - "This option works only in the sync loader mode" - how do I set > this mode? =============================================================================== Remove 'urlString' & 'lazy' properties, not clear usage currently, can be considered in future release. =============================================================================== > * labelString - Should this be renamed to 'text' to match other widgets? > * labelString - have we confirmed that innerHTML from Widget.egl works > here? =============================================================================== Done, rename to 'text'. And we haven't use innerHTML from Widget.egl. =============================================================================== > * DojoMobileSlider > * maximum - " Should not be smaller than the maximum value" in the comment? =============================================================================== That means the default value should less than the maximun value, modify the comments. =============================================================================== > * DojoMobileListCategory > * title - have we confirmed that innerHTML from Widget.egl works here? =============================================================================== Same with 'DojoMobileIconItem' =============================================================================== > * DojoMobileProgress > * intervalTime - should this just be 'interval', or 'updateInterval'? =============================================================================== Done, rename to 'interval'. =============================================================================== > * Is there a reason we have a 'setImage' function exposed but no 'getImage' > function? Is this function necessary since the imgPath field has a @Proprety > on it? =============================================================================== setImage() is used to set a progress indicator, I prefer to remove this method firstly, should enhance this when dojo mobile 1.8(dojo1.8 will enhance dojo mobile progress widget). =============================================================================== > * DojoMobileTab > * "If icon is not specified, the iconBase parameter of the parent widget is > used." - I don't see an iconBase parameter? > * icon* - should this be renamed to 'imagePath*' so it matchs > DojoMobileProgress? =============================================================================== 1. remove the misunderstanding comment, those comments are copied from dojo official site. 2. The two icons have different meanings, so rename them to 'selectedIcon' & 'deSelectedIcon' =============================================================================== > * DojoMobileTabContainer > * 'selection' Fix comment to indicate that it's the currently selected tab? > * Define poistion constants in DojoMobileLib (i.e. DojoLib.POSITION_TOP) > * Change 'layout' to 'tabPosition' to match DojoTabContainer.egl? > * The DojoTabContainer widget provides events for onTabSelected and > onTabRemoved. Are these events not needed for the mobile tab container? > * Is there a reason for the 'className' field? All widgets support the > 'class' field already. =============================================================================== 1. yes 2. done, move to DojoMobileLib 3. done, rename to 'tabPosition' 4. No, not supported in corresponding mobile widget, so not support current release. 5. No, no need to use 'className' field =============================================================================== > * DojoMobileTextArea > * rename 'expanding' to 'isExpandable'? > * rename 'value' to 'text' to match DojoTExtArea? > * Remove 'cols' and 'rows' if not supported. If supported, change to > numColumns and numRows to match DojoTextArea =============================================================================== 1. done, rename to 'isExpandable' 2. done, rename to 'text' 3. remove 'cols' & 'rows', has support 'weight' & 'height' =============================================================================== > * DojoMobileToolBarButton > * transition - Should this have a VEProperty and a default value? > * transition - Should the transition types be defined in DojoMobileLib? > * transitionDir - Should this have a VEProperty and a default value? > * transitionDir - Should the transition direction types be defined in > DojoMobileLib? > * icon - I assume this is supposed to be a path, so I suggest we change > this to be 'imagePath' to match DojoMobileProgress and update the comment to > indicate a path is expected > * labelString - Should this be renamed to 'text' to match other widgets? > * Is there a reason for the 'className' field? All widgets support the > 'class' field already. =============================================================================== 1 & 2. No, don't need VEProperty, no visible to user, and will the normal used 3 types into DojoMobileLib, and its defalut value is 'slide' 3 & 4. Same with above questions, default value is forward 5. rename to 'imagePath' 6. done, rename to 'text' 7. no need, remove it. =============================================================================== > * DojoMobileView > * Is there a reason for the 'className' field? All widgets support the > 'class' field already. > * This source code should be 'tightned up'. There is a lot of white space > * Rename 'scroll*' to 'canScroll*'? > * Rename 'swappable' to 'isSwappable'? =============================================================================== 1. remove it. 2. done, make into one line of one property 3. There are two scroll property, separate for vertical and horizontal 4. done, rename to 'isSwappable' =============================================================================== > * DojoMobileOpener > * Rename 'modal' to 'isModal'? > * Rename 'pop' to 'show'? This is what we use in other widgets. =============================================================================== 1. done, rename to 'isModal' 2. done, 'show' is a reserved word, rename to 'showOpener' & 'hideOpener' ===============================================================================
Created attachment 217593 [details] patch according to comment 6 Hi JiYong, pls help to review. Thanks.
(In reply to comment #33) > Created attachment 217593 [details] > patch according to comment 6 > > Hi JiYong, pls help to review. Thanks. Committed
Created attachment 217621 [details] patch to modify 'icon' to 'imagePath' Hi Brian, Two added modifications: 1. DojoMobileListItem - 'icon' to 'imagePath' 2. DojoMobileIconItem - 'icon' to 'imagePath' Hi Jiyong, Pls help to review this patch, Thanks.
This bug has been fixed in attachment 217855 [details]. The attachment includes following bug fixes: * BUG 383393 / Cluttered code appears when click DojoMobileDatePickerSample.egl The problem is that the mobile widgets' project in CVS server is configured with cp1252 encoding which causes locale's content like chinese, japanese characters messed up. I have reimported the locale package encoding in UTF-8. * BUG 383385, BUG 382889 / Widgets can't be added to mobile list item, DojoMobileListItem with children not right First, list item has been enhanced to support RUI widgets and Mobile widgets as its children, Second, a dojo mobile list item bug has been fix, dojo mobile list item might miscalculate its icon offset if icon has not loaded yet. In this patch, it has been fixed. * BUG 383178 / DatePicker initial date wrong when add to a view The bug is lead by the startup mechanism of dojox.mobile.SpinWheelDatePicker conficlts with the egl widget startup mechanism. In this patch, the startup mechanism of dojox.mobile.SpinWheelDatePicker has be rewritten to be compatible with egl widget startup mechanism. * BUG 383384 / Mobile checkbox's text attribute not working This is due to that the wrapper node of the input[type=checkbox] has been rewrotten to input[type=checkbox] child node by the egl widgets framework. So the text node in wrapper node get lost. It has been fixed. * BUG 382891 / DojoMobileProgress externalname incorrect It has been renamed. * BUG 383238 / Typo in webkit warning message It has been renamed. * BUG 383239 / Webkit warning not displayed after dropping a second widget It has been fixed by changing its warning message to always be the first child under body element. It has been tested in IE, Firefox, Chrome, Firefox. * BUG 356424 / Add Dojo Mobile to EDT renamed imagePath * BUG 383394 / Icons in DojoMobileIconContainerSample is not displayed correctly It has been renamed. * BUG 383504 / Miss css files under WebContent/dojox folder Reimported import css files.
Created attachment 217857 [details] edt.mobile.samples.20120626.update.txt The attachment includes following bug fixes: * BUG 356424 / Add Dojo Mobile to EDT Sample codes has been updated with the changes in mobile widgets. * BUG 383394 / Icons in DojoMobileIconContainerSample is not displayed correctly It has been renamed. * BUG 383510 / EGL Map not displayed correctly in VE or Preview As offical google map dev guide indicated, google map need to be initialized after body has been loaded, this bug has been fixed this patch.
This enhancement should have been resolved in attachment 217855 [details] and attachment 217857 [details]. Jiyong, would you pls help review and commit these two attachments if time is available? Brain, if anything updated is not proper, let me know.
[Verified in build]: 0.8.1.v201206271108
