Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356412 - Bad error handling on file creation
Summary: Bad error handling on file creation
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 0.3 M2   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-31 17:10 EDT by John Arthorne CLA
Modified: 2011-09-01 10:53 EDT (History)
0 users

See Also:


Attachments
Screen shot (28.68 KB, image/png)
2011-08-31 17:12 EDT, John Arthorne CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2011-08-31 17:10:36 EDT
Using I20110830 on orion.eclipse.org


- Create a new top level folder
- Under it, create a file called ":a" (no quotes, just a colon followed by a letter)

-> This fails, and the UI displays a raw HTML document in the status display area.

- Attempt to navigate into the folder containing the bad file

-> Another error occurs. This folder is now permanently broken
Comment 1 John Arthorne CLA 2011-08-31 17:12:11 EDT
Created attachment 202566 [details]
Screen shot
Comment 2 John Arthorne CLA 2011-09-01 10:53:00 EDT
There are two parts to the fix. First, the server was returning a ServletException rather than an JSON object representing an IStatus:

http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=ea3d441c6c06285db2190c3b32f066e142b0941c

I also noticed while debugging that if the deferred timeeouts, then the deferred error object gets sent to status.js, which doesn't know how to display this. You end up seeing [Object] in the status area rather than the message. We might want to special case this to give a more informative message, but for now I have just let the dojo deferred "timeout exceeded" message be shown to the user.

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=008cda62d61e3c1ac236e44bb934c4a48d490ba1