Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356230 - [dstore] remote search sometimes returns incomplete results in view
Summary: [dstore] remote search sometimes returns incomplete results in view
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3.1   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 356231
  Show dependency tree
 
Reported: 2011-08-30 13:08 EDT by David McKnight CLA
Modified: 2011-09-13 08:15 EDT (History)
2 users (show)

See Also:
xuanchen: review+
kjdoyle: review+

Attachments
patch to not fire event until search completion (2.49 KB, patch)
2011-08-30 13:10 EDT, David McKnight CLA 		no flags Details | Diff
updated patch (3.26 KB, patch)
2011-08-30 13:15 EDT, David McKnight CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David McKnight CLA 2011-08-30 13:08:28 EDT 
The remote search support can return an incomplete list of results in the search view.  This appears to be a result of the firing of a refresh event before the search has completed.
Comment 1 David McKnight CLA 2011-08-30 13:10:22 EDT 
Created attachment 202442 [details]
patch to not fire event until search completion
Comment 2 David McKnight CLA 2011-08-30 13:11:04 EDT 
Xuan and Kevin, could you please review this patch?
Comment 3 David McKnight CLA 2011-08-30 13:15:33 EDT 
Created attachment 202444 [details]
updated patch
Comment 4 Kevin Doyle CLA 2011-08-31 10:13:14 EDT 
Review +.
Comment 5 Xuan Chen CLA 2011-08-31 11:11:10 EDT 
The fix looks good.
Comment 6 David McKnight CLA 2011-08-31 11:19:50 EDT 
Thanks for the reviews.  I've committed the change to the HEAD stream.