356214 – [LML] Need to be able to specify paths of remote commands

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356214 - [LML] Need to be able to specify paths of remote commands

Summary: [LML] Need to be able to specify paths of remote commands

Status:	RESOLVED FIXED

Alias:	None

Product:	PTP
Classification:	Tools
Component:	RM (show other bugs)
Version:	5.0.1
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	5.0.2
Assignee:	Greg Watson
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-08-30 11:17 EDT by Greg Watson
Modified:	2012-05-23 16:54 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
Client side implementation (254.73 KB, patch) 2011-08-30 12:45 EDT, Claudia Knobloch	no flags	Details \| Diff
Client side implementation (255.34 KB, patch) 2011-08-30 13:33 EDT, Claudia Knobloch	no flags	Details \| Diff
Client side implementation - Part 2 (1016 bytes, patch) 2011-08-30 14:59 EDT, Claudia Knobloch	no flags	Details \| Diff
patch-file for org.eclipse.ptp.rm.lml.da (5.25 KB, patch) 2011-08-30 16:51 EDT, wfrings	g.watson: iplog+	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Greg Watson

2011-08-30 11:17:44 EDT

The LML monitoring fails on some systems because the paths are not necessarily set up correctly, so commands such as qstat may not be available.

The RM configuration XML should be able to be used to specify the paths of these remote commands. A suggested XML syntax is:

	<monitor-data schedulerType="torque">
		<driver>
			<cmd name="jobinfo" exec="/opt/torque/2.5.7/bin/qstat"/>
			<cmd name="nodeinfo" exec="/opt/torque/2.5.7/bin/pbsnodes"/>
		</driver> 
	</monitor-data>

The DA driver would match the schedulerType "torque" to its know schedulers, then use the commands when obtaining job/node information.

Comment 1 Greg Watson

2011-08-30 11:18:08 EDT

The XML schema has been updated to support this syntax.

Comment 2 Claudia Knobloch

2011-08-30 12:45:47 EDT

Created attachment 202438 [details]
Client side implementation

Comment 3 Claudia Knobloch

2011-08-30 13:33:13 EDT

Created attachment 202446 [details]
Client side implementation

In the 2. and all after wards created requests (LML files) still the request tag is missing.

Still work on it.

Comment 4 Greg Watson

2011-08-30 14:53:47 EDT

I've tested this with existing RMs and they appear to function correctly.

Comment 5 Claudia Knobloch

2011-08-30 14:59:40 EDT

Created attachment 202452 [details]
Client side implementation - Part 2

Second part, now there is always a request tag generated when the reuquest LML file is generated.

Comment 6 wfrings

2011-08-30 15:27:22 EDT

Is the driver tag unique or could it occur often than one in the monitor tag?
If this is the case, how could LML_da_driver decide which one of these driver should be taken? And the driver tag needs also a name or id to distinguish its instances.

Comment 7 Greg Watson

2011-08-30 15:45:27 EDT

There is not currently an attribute (name) on the driver. The job scheduler is specified by the schedulerType attribute and applies to all the elements in the monitor-data section. 

I'm not sure there is any need to provide commands (drivers) for more than one job scheduler, since each configuration file is really specific to a particular system/job scheduler configuration, the user can always create another configuration if necessary.

Comment 8 wfrings

2011-08-30 16:51:49 EDT

Created attachment 202458 [details]
patch-file for org.eclipse.ptp.rm.lml.da

patch-file for org.eclipse.ptp.rm.lml.da version 1.11 -> 1.12:
- supports now new LML request structure (driver, command)

Comment 9 Greg Watson

2011-08-30 18:35:54 EDT

After changing the default job scheduler to TORQUE, this works for current RMs. I'll try using the new driver section next.

Comment 10 Greg Watson

2011-08-30 18:42:39 EDT

This is working on keenland which requires a modified path for the jobs and nodes commands.

Comment 11 Greg Watson

2011-09-02 09:32:21 EDT

Applied to ptp_5_0 and HEAD