Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356183 - In Single click mode each click in Git Repositories view starts check out
Summary: In Single click mode each click in Git Repositories view starts check out
Status: VERIFIED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.1   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-30 08:03 EDT by Dani Megert CLA
Modified: 2011-12-06 06:21 EST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-08-30 08:03:34 EDT 
1.1.0.201108281957.

In Single click mode each click in Git Repositories view starts a check out. It took me a while to figure out why my machine was working all the time.

Given that check out is quite a heavyweight action, I would not do it on single click.
Comment 1 Jens Baumgart CLA 2011-08-31 04:23:16 EDT 
Checkout of a branch is normally done on double click.
If you enable single click in preferences, the "open" operations are already done on a single click. So I think Repositories View behaves correctly.
Comment 2 Dani Megert CLA 2011-08-31 04:42:01 EDT 
(In reply to comment #1)
> Checkout of a branch is normally done on double click.
> If you enable single click in preferences, the "open" operations are already
> done on a single click. So I think Repositories View behaves correctly.

"Open" is not the same as checkout. Check out takes much longer and it changes my workspace content. Hence it should not happen on single click.
Comment 3 Dani Megert CLA 2011-09-21 09:36:20 EDT 
I need to increase the severity of this as it makes it very hard to compare (Synchronize) two tags or branches because it immediately starts to check out as soon as I select an entry.
Comment 4 Dani Megert CLA 2011-11-17 06:42:26 EST 
Pushed http://egit.eclipse.org/r/4640 for review.

This fix makes sure that double-click is needed for check out but still uses the open listener for opening files from the working directory.
Comment 5 Brian de Alwis CLA 2011-11-18 09:47:58 EST 
I support Dani's change.  In my case, I was selecting branches to examine branch histories with the History view.  I was puzzled as to why certain projects were disappearing.
Comment 6 Dani Megert CLA 2011-11-30 04:18:44 EST 
Ping! The patch is ready.
Comment 7 Jens Baumgart CLA 2011-11-30 05:08:27 EST 
Fixed with commit 25a7f1ce9436bdabe2eb82c4f6fd4370404083e0
Comment 8 Dani Megert CLA 2011-11-30 05:10:39 EST 
Thanks Jens!
Comment 9 Dani Megert CLA 2011-12-06 06:21:27 EST 
Verified in 1.2.0.201112051848.