Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356158 - The deployment should prompt user when no target project is specified in the DD file
Summary: The deployment should prompt user when no target project is specified in the ...
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P1 normal (vote)
Target Milestone: ---   Edit
Assignee: Yun Feng Ma CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-30 02:48 EDT by fahua jin CLA
Modified: 2017-02-23 14:18 EST (History)
3 users (show)

See Also:

Attachments
Patch (13.75 KB, patch)
2011-09-06 05:00 EDT, Yun Feng Ma CLA 		no flags Details | Diff
Patch-1 (13.93 KB, patch)
2011-09-06 20:55 EDT, Yun Feng Ma CLA 		no flags Details | Diff
Patch (14.88 KB, patch)
2011-09-08 03:32 EDT, Yun Feng Ma CLA 		no flags Details | Diff
Patch (17.56 KB, patch)
2011-09-08 05:00 EDT, Yun Feng Ma CLA 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description fahua jin CLA 2011-08-30 02:48:58 EDT 
Build Identifier: 20110830

In the RBD, if no target project is specified in the dd file, then it prompts 'the target is not specified in the ...., do you want to open the dd file?' But in the EDT, no such dialog is displayed & only prints error message in the deployment view.


Reproducible: Always

Steps to Reproduce:
1. Create an EGL 'Web Client Project'
2. Create an EGL RUI handler
3. Right click the dd file under the project, and click deploy. Expect to see the dialog tells user that no target is specified in the dd file.
Comment 1 Yun Feng Ma CLA 2011-09-06 05:00:05 EDT 
Created attachment 202792 [details]
Patch

Here is a patch, please review it. Thanks.
Comment 2 Yun Feng Ma CLA 2011-09-06 20:55:52 EDT 
Created attachment 202850 [details]
Patch-1

Please use Patch-1. Thanks.
Comment 3 Yun Feng Ma CLA 2011-09-08 03:32:50 EDT 
Created attachment 202970 [details]
Patch

New patch. Thanks.
Comment 4 Yun Feng Ma CLA 2011-09-08 05:00:00 EDT 
Created attachment 202976 [details]
Patch

Patch
Comment 5 Yun Feng Ma CLA 2011-09-08 05:09:48 EDT 
Fix is in now. Resolve this one. Thanks.
Comment 6 fahua jin CLA 2011-09-19 02:29:57 EDT 
(In reply to comment #5)
> Fix is in now. Resolve this one. Thanks.

Verified in 0.7.0.v201109172101.
Comment 7 fahua jin CLA 2011-10-19 21:40:48 EDT 
The problem existed in build 0.7.0.v201110180903.
Comment 8 Yun Feng Ma CLA 2011-10-21 01:08:54 EDT 
This is a regression issue, fixed now.
Comment 9 fahua jin CLA 2011-10-31 03:15:20 EDT 
(In reply to comment #8)
> This is a regression issue, fixed now.

Test case 2:

1) Create an EGL project with RUI & service support.
2) Create an RUI Handler.
3) Open the DD editor and specified a target deploy project in the DD editor.
4) Close the DD editor.
5) Delete the project created in the 1st step.
6) Right click the DD editor, and deploy the project. No dialog prompts the target project cannot be found.
Comment 10 fahua jin CLA 2011-10-31 03:15:52 EDT 
Reopen the defect.
Comment 11 Brian Svihovec CLA 2011-11-04 09:51:21 EDT 
Is there something specific that keeps breaking this feature, or is the breakage unpredictable?
Comment 12 Yun Feng Ma CLA 2011-11-07 00:42:14 EST 
Fixed.

The reason is that the target project has been deleted, but the target project is still in egldd file. Now checking the existence of the target project before deployment.
Comment 13 fahua jin CLA 2011-11-10 03:03:36 EST 
(In reply to comment #12)
> Fixed.
> 
> The reason is that the target project has been deleted, but the target project
> is still in egldd file. Now checking the existence of the target project before
> deployment.

Verified the defect in 0.7.0.v201111091612, hope I will not reopen it again :-)
Comment 14 fahua jin CLA 2011-11-13 21:27:40 EST 
I remember that I've closed it, not sure it's still in resolve state.