Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356143 - Pull DojoDialogLib out of Samples and into Dojo widgets project
Summary: Pull DojoDialogLib out of Samples and into Dojo widgets project
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Huang Ji Yong CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-29 23:03 EDT by Will Smythe CLA
Modified: 2017-02-23 14:19 EST (History)
1 user (show)

See Also:

Attachments
RemoveDependency (7.10 KB, patch)
2011-09-16 03:16 EDT, Huang Ji Yong CLA 		lasher: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Will Smythe CLA 2011-08-29 23:03:02 EDT 
DojoDialogLib provides nice utility functions for showing various messages (error, warning, question, etc) to a user. This library logically belongs in the Dojo widgets project, but was shipped in Dojo samples because it hadn't been thoroughly tested. I think this is something that needs to be moved into the Dojo widgets since displaying messages to users is very common in GUI apps and developers should not have to import a sample project to get this.
Comment 1 Will Smythe CLA 2011-08-29 23:04:41 EDT 
I believe there is a sample that goes with this library - it can stay in Dojo Samples. 

Also, there are icons for the various messages that will need to be moved into the Dojo widgets project as part of this task.
Comment 2 Tony Chen CLA 2011-08-29 23:20:28 EDT 
There's only a few widget can run at the moment. Set this bug to I14 when more widgets are expected to run.
Comment 3 Huang Ji Yong CLA 2011-09-15 22:42:57 EDT 
Hi Will,
DojoDialogLib depends on RUI widget project (HistroyHelper). If it is pulled into Dojo project, Dojo will have to depend on RUI widgets. Do you think this is appropriate?
Comment 4 Will Smythe CLA 2011-09-15 23:29:09 EDT 
Why does it depend on HistoryHelper? And is there an alternative? 

I don't think the Dojo widgets project should depend on the RUI widgets project ..
Comment 5 Huang Ji Yong CLA 2011-09-16 03:16:26 EDT 
Created attachment 203472 [details]
RemoveDependency
Comment 6 Huang Ji Yong CLA 2011-09-16 03:17:19 EDT 
Add DojoDialogLib to Dojo widgets.
Remove dependency on RUI widgets.
Comment 7 Will Smythe CLA 2011-11-02 00:22:14 EDT 
Looks good.