Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356088 - Corrupted diagram
Summary: Corrupted diagram
Status: RESOLVED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: Diagram Editor (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.0.1   Edit
Assignee: Stefan Dimov CLA
QA Contact: Stefan Dimov CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-29 10:48 EDT by Stefan Dimov CLA
Modified: 2011-09-07 13:45 EDT (History)
3 users (show)

See Also:
stefan.dimov: indigo+
stefan.dimov: juno+
stefan.dimov: pmc_approved? (david_williams)
stefan.dimov: pmc_approved? (raghunathan.srinivasan)
stefan.dimov: pmc_approved? (naci.dai)
stefan.dimov: pmc_approved? (deboer)
stefan.dimov: pmc_approved? (neil.hauge)
stefan.dimov: pmc_approved? (kaloyan)
cbridgha: pmc_approved+
petya.sabeva: review+
stefan.dimov: review+

Attachments
patch for HEAD (18.48 KB, patch)
2011-08-29 11:15 EDT, Stefan Dimov CLA 		no flags Details | Diff
patch for R3_0_maintenance release (16.67 KB, patch)
2011-08-29 11:16 EDT, Stefan Dimov CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Dimov CLA 2011-08-29 10:48:24 EDT 
In some specific cases an already created diagram opens, but is corrupted. It's hard to describe a specific scenario.
Comment 1 Stefan Dimov CLA 2011-08-29 11:15:32 EDT 
Created attachment 202335 [details]
patch for HEAD
Comment 2 Stefan Dimov CLA 2011-08-29 11:16:07 EDT 
Created attachment 202336 [details]
patch for R3_0_maintenance release
Comment 3 Stefan Dimov CLA 2011-08-29 11:34:58 EDT 
Both patches (for HEAD and R3_0_maintenance) committed and released
Comment 4 Stefan Dimov CLA 2011-08-30 10:36:01 EDT 
I just came from vacation and everything is on fire here, so I've omitted (unintentionally) to let this go through the PMC process. Sorry about that.
Comment 5 Stefan Dimov CLA 2011-08-30 11:20:03 EDT 
In some specific cases when the user opens the diagram it's corrupted.

No workaround

The fix was tested manually.

The method ModelIntegrationUtil.getDiagramByProject(IProject) sometimes wasn't able to obtain the project diagram and returns null. The fixes uses weak reference mapping (in order to avoid leaks) between projects and diagrams.

The risk is low.
Comment 6 Chuck Bridgham CLA 2011-08-31 10:27:30 EDT 
The fix seems safe enough - I approve
Comment 7 Neil Hauge CLA 2011-09-07 13:45:24 EDT 
This patch was committed to head and maintenance.