Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356028 - Consideration for org.junit 4.10
Summary: Consideration for org.junit 4.10
Status: RESOLVED FIXED
Alias: None
Product: Orbit
Classification: Tools
Component: bundles (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: Juno M7   Edit
Assignee: DJ Houghton CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 377553 (view as bug list)
Depends on: 377747
Blocks: 356065
  Show dependency tree
 
Reported: 2011-08-28 13:03 EDT by Bryan Hunt CLA
Modified: 2013-02-14 04:30 EST (History)
6 users (show)

See Also:


Attachments
org.junit_v4.10.zip (368.14 KB, application/x-zip)
2012-04-24 06:53 EDT, Markus Keller CLA
no flags Details
Fixes for v4_10_0 branch (2.14 KB, patch)
2012-04-26 09:04 EDT, Markus Keller CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bryan Hunt CLA 2011-08-28 13:03:33 EDT
It appears that JUnit 4.9 is getting close to release.  When it is added to orbit, would it be possible to get the build without hamcrest?  Having hamcrest included in the junit bundle is problematic.  For example, the latest version of JMock needs hamcrest 1.3.  Including the hamcrest 1.3 bundle with the junit 4.8 bundle causes very bad things to happen.
Comment 1 Markus Keller CLA 2011-08-29 09:33:20 EDT
The org.junit bundles from Orbit never included Hamcrest, and I don't see a reason why this would be changed now.

According to http://tech.groups.yahoo.com/group/junit/message/23576 , JUnit 4.9 has been released and can be fetched from here:
https://github.com/KentBeck/junit/downloads
Comment 2 Bryan Hunt CLA 2011-08-29 11:10:55 EDT
Ah, my bad, I had just assumed that the junit bundle included the hamcrest library.  It seems the problems I've encountered may stem from:

Require-Bundle: org.hamcrest.core;bundle-version="1.1.0";visibility:=reexport

I think the reexport is what is causing my problems, so I think I need to change my request to remove the reexport when putting junit 2.9 into Orbit.
Comment 3 Bryan Hunt CLA 2011-11-13 18:23:56 EST
I have JUnit 10 built as a bundle / feature.  Should I attach it for contribution?
Comment 4 David Williams CLA 2011-11-13 21:34:20 EST
Bryan, sorry if I'm stating the obvious, but the a third party bundle needs to go through the Eclipse Foundation's IP Process first (i.e. a committer on an Eclipse Project file a CQ files, etc.). 

(Plus, a new addition would be best as a separate bugzilla entry, as I think this one is about a possible bug in an existing one?) 

I'll assign this to DJ, as he maintains the JUnit family of bundles so he can decide course of action. 

Thanks,
Comment 5 Markus Keller CLA 2011-11-14 06:17:25 EST
The latest JUnit version is 4.10:
http://tech.groups.yahoo.com/group/junit/message/23717

(In reply to comment #2)
> Ah, my bad, I had just assumed that the junit bundle included the hamcrest
> library.  It seems the problems I've encountered may stem from:
> 
> Require-Bundle: org.hamcrest.core;bundle-version="1.1.0";visibility:=reexport
> 
> I think the reexport is what is causing my problems, so I think I need to
> change my request to remove the reexport when putting junit 2.9 into Orbit.

We can't remove the reexport, since that would be a breaking change. If the reexport is really the problem, then you have to come up with a proof for that and discuss the concrete problem with the OSGi people.
Comment 6 Bryan Hunt CLA 2011-11-14 08:39:40 EST
> We can't remove the reexport, since that would be a breaking change. If the
> reexport is really the problem, then you have to come up with a proof for that
> and discuss the concrete problem with the OSGi people.

I think I remember how to reproduce the problem.  I'll see if I can come up with a test case that I can attach.
Comment 7 Markus Keller CLA 2012-01-19 17:36:08 EST
JDT's CQ for JUnit 4.10 is https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5958
Comment 8 Markus Keller CLA 2012-04-24 06:53:48 EDT
Created attachment 214453 [details]
org.junit_v4.10.zip

DJ, the IPZilla has been approved. Could you please release the new version to Orbit?
Comment 9 DJ Houghton CLA 2012-04-24 12:37:36 EDT
Ok, I've added Bug 377553 to track release into Orbit.
Here is the Orbit CQ I just opened to piggy-back off the JDT one:
   https://dev.eclipse.org/ipzilla/show_bug.cgi?id=6442
Comment 10 Markus Keller CLA 2012-04-26 09:04:42 EDT
Created attachment 214598 [details]
Fixes for v4_10_0 branch

This patch fixes problems in the v4_10_0 branch in the Orbit CVS:
- project name should contain version
- classpath problems: missed PDE container, missed EE, didn't export junit.jar


> Ok, I've added Bug 377553 to track release into Orbit.

Not sure what that bug is for. This bug is already for Orbit.
Bug 356065 is the JDT/UI bug (blocked by this bug).
Comment 11 DJ Houghton CLA 2012-04-26 09:09:30 EDT
*** Bug 377553 has been marked as a duplicate of this bug. ***
Comment 12 DJ Houghton CLA 2012-04-26 09:11:52 EDT
Oops, for some reason I thought this was the JDT bug. I've closed the other as a duplicate. 

Thanks, I released the patch. The latest build page doesn't seem to contain last night's build with the changes. I've added the bug as a blocker.
Comment 13 DJ Houghton CLA 2012-04-27 07:54:00 EDT
Build is available here: 
   http://build.eclipse.org/orbit/committers/
Please take a look at the bundle available from the build. I won't close this bug until the bundle is verified.
Thanks.
Comment 14 Markus Keller CLA 2012-04-27 09:47:36 EDT
Thanks, I verified that
- http://build.eclipse.org/orbit/committers/orbit-I/20120427112720/I20120427112720/repository/plugins/org.junit_4.10.0.v4_10_0_v20120426-0900.jar and the source bundle are looking good
- they also work fine when I hack them into an install
Comment 15 DJ Houghton CLA 2012-04-27 16:49:12 EDT
Closing.