Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 356020 - GitFileHistoryProvider.getFileHistoryFor fails with "Empty path not permitted."
Summary: GitFileHistoryProvider.getFileHistoryFor fails with "Empty path not permitted."
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 356021
  Show dependency tree
 
Reported: 2011-08-28 07:28 EDT by Thomas Hallgren CLA
Modified: 2011-08-30 11:14 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Hallgren CLA 2011-08-28 07:28:20 EDT 
Some projects are also repositories in the sense that they contain the actual .git folder. The GitFileHistory constructor is not able to handle that. It calls the RemoteMapping.getRepoRelativePath() and receives an empty path. It then tries to create a path filter which fails with an "Empty path not permitted." message.

The solution is probably to check for empty paths and omit the path filter when that's the case.
Comment 1 Thomas Hallgren CLA 2011-08-28 13:27:35 EDT 
I pushed a patch to Gerrit. http://egit.eclipse.org/r/#change,4080
Comment 2 Matthias Sohn CLA 2011-08-30 11:14:34 EDT 
merged as 4da79c1b456475765193193d8c81285ddcaf0304