Community
Participate
Working Groups
Due to recent changes in the build system (bug 355963) plug-ins and features may no longer have the same id. Unfortunately the HtmlText component uses the same ID org.eclipse.mylyn.htmltext for it's bundle and feature. To resolve the conflict we need to either rename the feature or plug-in id. The standard Mylyn convention is to append ui, core, tests etc. to plug-in ids, e.g.: Feature: org.eclipse.mylyn.htmltext Plug-in: org.eclipse.mylyn.htmltext.ui The alternative is to change the feature ID to org.eclipse.mylyn.htmltext.feature. Changing the feature ID would cause problems for users who have the feature already installed. These users would need to uninstall the old feature and re-install the new feature.
I'm in favor of changing the plug-in id since that affect integrators rather than users.
(In reply to comment #1) > I'm in favor of changing the plug-in id since that affect integrators rather > than users. I agree. Adding a .ui to the bundles id would be the easiest. In addition to the changes in the bundles MANIFEST.MF the Id must be also changed org.eclipse.mylyn.htmltext.HtmlTextActivator.PLUGIN_ID
Thanks for the quick feedback. I have renamed the bundle and folder to org.eclipse.mylyn.htmltext.ui. Everyone who has imported the project into a workspace will need to re-import it under the new name. The commit id is: 35e140b77a28e8c87dce29a027262fadcf489579.
Created attachment 202285 [details] mylyn/context/zip
Don't we introduce similar problems for the end-user when we change the plug-in id? As far as I see it p2 will not match these two plug-ins anymore and install the new one on top of the old one, won't it? If really no other problems occur still the ui parts will appear twice.
(In reply to comment #5) > Don't we introduce similar problems for the end-user when we change the plug-in > id? In this case there shouldn't be any conflicts when both bundles are installed. > As far as I see it p2 will not match these two plug-ins anymore and install the > new one on top of the old one, won't it? My understanding is that p2 will remove plug-ins that are no longer referenced if the corresponding feature is uninstalled. > If really no other problems occur still the ui parts will appear twice. True, but in this case we are lucky since the plug-ins does not contribute any UI extensions.
