Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355957 - 'Commit Changes' dialog should not enable 'Commit' if there's no comment
Summary: 'Commit Changes' dialog should not enable 'Commit' if there's no comment
Status: VERIFIED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 1.1   Edit
Assignee: Kevin Sawicki CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-26 10:23 EDT by Dani Megert CLA
Modified: 2011-09-16 08:33 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-08-26 10:23:50 EDT 
1.1.0.201108251914.

The 'Commit Changes' dialog should not enable 'Commit' if there's no comment. Currently I get a second dialog telling me that I have to enter the comment.

Eclipse practice is to disable the button and show that warning inside the status area of the dialog.
Comment 1 Kevin Sawicki CLA 2011-08-31 15:29:33 EDT 
Proposed fix pushed to: http://egit.eclipse.org/r/#change,4099
Comment 2 Jens Baumgart CLA 2011-09-01 09:54:35 EDT 
Merged as commit 7aad71169277621e93ab34172f86b1f0a32413b9
Comment 3 Dani Megert CLA 2011-09-16 08:33:47 EDT 
Verified in 1.1.0.201109151100-r.