Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355931 - Result.DetailedMessage is ignored for pushCommand
Summary: Result.DetailedMessage is ignored for pushCommand
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.4 RC1   Edit
Assignee: Malgorzata Janczarska CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-26 06:38 EDT by Tomasz Zarna CLA
Modified: 2012-02-10 12:52 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2011-08-26 06:38:00 EDT
If for any reason pushing fails, returning just RemoteRefUpdate.Status is not enough for some cases. One of them, mentioned on bug 349699, end up with REJECTED_OTHER_REASON and nothing more. The fix I initially provided, started to use "DetailedMessage" field in "Result" object[1]. However, the field is never displayed to the user. All she sees is a warning with "REJECTED_OTHER_REASON" message.

As a workaround I concatenated "Message" and the string I originally used as "DetailedMessage".

[1] Full response from a push job that failed:

{
  "Id": "QJEpjMvPABASD9Qjr7S9FQ",
  "Location": "http://localhost:8080/task/id/QJEpjMvPABASD9Qjr7S9FQ",
  "Message": "Pushing origin done",
  "PercentComplete": 100,
  "Result": {
    "Code": 0,
    "DetailedMessage": "object 34efaead64df04f2b2da434428b775cf4436d977 missing",
    "HttpCode": 200,
    "Message": "REJECTED_OTHER_REASON",
    "Severity": "Warning"
  },
  "Running": false
}
Comment 1 Malgorzata Janczarska CLA 2012-02-10 12:52:21 EST
Fixed, now DetailedMessage will appear after ":". Remove walkarounds in server.