Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355893 - Generate Parts more consistently
Summary: Generate Parts more consistently
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Scott Greer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-25 16:06 EDT by Scott Greer CLA
Modified: 2017-02-23 14:18 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Greer CLA 2011-08-25 16:06:43 EDT 
First, normalize the LibraryTemplate so that the genClassBody logic for all JS-gen'ed parts comes from one place, EGLClassTemplate.  

Next, normalize comma-delimiting between generated functions by having logic that gens a function first emit a comma.  Doing so allows overrides that no-op one or more functions without resulting in JavaScript syntax errors as a result of spurious commas.
Comment 1 Scott Greer CLA 2011-08-25 22:06:26 EDT 
Implemented.
Comment 2 Lisa Lasher CLA 2011-08-26 18:03:47 EDT 
changing to Enhancement, as this isn't really a defect.
Comment 3 Lisa Lasher CLA 2011-11-04 11:42:24 EDT 
Closing this work item