Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355868 - Commit hyperlink detector decorates the wrong characters
Summary: Commit hyperlink detector decorates the wrong characters
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Benjamin Muskalla CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-25 11:59 EDT by Benjamin Muskalla CLA
Modified: 2012-03-23 12:02 EDT (History)
2 users (show)

See Also:

Attachments
description of bug 348237 (4.94 KB, image/png)
2011-08-26 14:43 EDT, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Muskalla CLA 2011-08-25 11:59:24 EDT 
Seems the hyperlink detector has a broken hyperlink detection for some cases. See bug 355525 comment 1

--------------
Fixed and committed

2011-08-23 11:16:12 
a7e2ce49919ee3bdc5dd50b04815537375261899
Comment 1 Steffen Pingel CLA 2011-08-25 14:14:27 EDT 
Might be a bug in the task editor highlighting code since the hyperlink was working as expected.
Comment 2 Steffen Pingel CLA 2011-08-26 14:43:15 EDT 
Created attachment 202249 [details]
description of bug 348237
Comment 3 Steffen Pingel CLA 2011-08-26 14:44:13 EDT 
Another example for broken text decoration is bug 348237 (see screenshot).
Comment 4 Steffen Pingel CLA 2011-08-27 17:11:59 EDT 
The rendering problem on bug 348327 was caused by the changes for bug 348969 and are unrelated to the hyperlink problems. Sorry for the confusion. Moving back to EGit.
Comment 5 Steffen Pingel CLA 2011-08-27 17:19:28 EDT 
Definitely looks like a problem in the hyperlink detector. The region is not reported correctly. I recommend GerritConnectorUi.findHyperlinks() as an example. Using a regexp to search the text is faster and simpler that tokenizing the entire document.
Comment 6 Steffen Pingel CLA 2012-01-20 15:39:21 EST 
Benjamin, do you think we could get this fixed for the next EGit release?
Comment 7 Steffen Pingel CLA 2012-02-04 09:48:59 EST 
I have pushed a review: https://git.eclipse.org/r/#change,5054. 

Would be great if this fix could be considered for a 1.3 service release.
Comment 8 Steffen Pingel CLA 2012-03-12 06:15:14 EDT 
Any thoughts on the proposed change?
Comment 9 Benjamin Muskalla CLA 2012-03-23 12:02:23 EDT 
Rebased, tested, merged. Thanks a lot Steffen!