Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355860 - [hotbug]JSFFacetInstallDataModelProvider dispose method does not remove all listeners it adds
Summary: [hotbug]JSFFacetInstallDataModelProvider dispose method does not remove all l...
Status: RESOLVED FIXED
Alias: None
Product: Java Server Faces
Classification: WebTools
Component: Core (show other bugs)
Version: 3.2.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4.0 RC1   Edit
Assignee: Ian Trimble CLA
QA Contact:
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-25 11:15 EDT by Gloria Yadira Torrealba Melendez CLA
Modified: 2012-05-16 17:45 EDT (History)
5 users (show)

See Also:
raghunathan.srinivasan: pmc_approved? (cbridgha)
neil.hauge: pmc_approved+
raghunathan.srinivasan: pmc_approved? (kaloyan)
raghunathan.srinivasan: pmc_approved? (david_williams)
raghunathan.srinivasan: review+

Attachments
dispose method added (2.91 KB, text/plain)
2012-03-29 15:33 EDT, Gloria Yadira Torrealba Melendez CLA 		raghunathan.srinivasan: iplog+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gloria Yadira Torrealba Melendez CLA 2011-08-25 11:15:20 EDT 
Build Identifier: 3.2.4

In the initLibraryInstallDelegate method, a property change listener is added
to the install delegate. The listener should be removed.

The fix could be as the proposed for the bug 352887, which is the same scenario but for WebServices.

Reproducible: Always
Comment 1 agueda martinez CLA 2012-01-31 14:47:37 EST 
Hello, is there any outlook for this bug?
Comment 2 Gloria Yadira Torrealba Melendez CLA 2012-03-29 15:33:48 EDT 
Created attachment 213360 [details]
dispose method added
Comment 3 Gloria Yadira Torrealba Melendez CLA 2012-03-29 15:36:35 EDT 
patch to resolve this issue added. I hope this helps speed up the solution.
Comment 4 Carl Anderson CLA 2012-03-29 16:05:31 EDT 
The adopter, IBM, would like this change made to HEAD for WTP 3.4.0, and then other bugs will be opened to get this backported to an older level.
This fixes a memory leak caused by the PropertyChangeListener not being disposed.
Comment 5 Raghunathan Srinivasan CLA 2012-03-29 16:14:52 EDT 
Hotbug request accepted. Thanks for the patch. We will review.
Comment 6 Ian Trimble CLA 2012-04-09 17:24:05 EDT 
Fix committed to HEAD at 2012/04/09 02:23PM PDT.
Comment 7 Raghunathan Srinivasan CLA 2012-05-14 17:09:19 EDT 
    Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

This is a hotbug request
    Is there a work-around? If so, why do you believe the work-around is insufficient? 
No workaround
    How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 
Manual testing
    Give a brief technical overview. Who has reviewed this fix? 
Fixes a memory leak
    What is the risk associated with this fix? 
low
Comment 8 Raghunathan Srinivasan CLA 2012-05-16 17:45:16 EDT 
Released for RC1