Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355859 - The bundle org.eclipse.datatools.sqltools.result has an unnecessary dependency to org.eclipse.jface.text
Summary: The bundle org.eclipse.datatools.sqltools.result has an unnecessary dependenc...
Status: RESOLVED FIXED
Alias: None
Product: Data Tools
Classification: Tools
Component: SQL Results View (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 1.10   Edit
Assignee: Brian Payton CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-25 11:03 EDT by Troy Bishop CLA
Modified: 2012-05-15 21:28 EDT (History)
1 user (show)

See Also:

Attachments
possible patch (865 bytes, patch)
2011-08-25 11:04 EDT, Troy Bishop CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Troy Bishop CLA 2011-08-25 11:03:16 EDT 
Build Identifier: 

The bundle org.eclipse.datatools.sqltools.result currently has a dependency to org.eclipse.jface.text when it is not needed.  To verify, I tried removing it and everything still compiles successfully.  Could you please remove this dependency as it ends up pulling in a lot of the JFace (UI) dependencies when they are not needed.

Reproducible: Always
Comment 1 Troy Bishop CLA 2011-08-25 11:04:53 EDT 
Created attachment 202156 [details]
possible patch
Comment 2 Brian Payton CLA 2012-05-15 21:27:44 EDT 
You are correct.  I've removed dependency on o.e.jface.text from the MANIFEST.MF of o.e.d.sqltools.result.

Here's the Git commit record:
http://git.eclipse.org/c/datatools/org.eclipse.datatools.sqltools.git/commit/?id=04b4246ebe4d4c7c8455ed185bbc1c29653d923e