Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 355837 - Synchronize view: does not refresh when clicking icon or F5
Summary: Synchronize view: does not refresh when clicking icon or F5
Status: VERIFIED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 critical (vote)
Target Milestone: ---   Edit
Assignee: Dariusz Luksza CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-25 09:57 EDT by Dani Megert CLA
Modified: 2012-10-10 03:43 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-08-25 09:57:47 EDT 
org.eclipse.egit.ui_1.1.0.201108230343.jar


1. in workspace A: commit and push a change to project A from repo A
2. in workspace B: Team > Synchronize and select to compare project A with 
   remote master
   ==> good: change from 1. appears
3. in workspace A: commit and push a change to a project A
4. in workspace B click on the 'Synchronize' icon or F5
   ==> not good: change from 3. does not show up
Comment 1 Dani Megert CLA 2011-09-19 08:41:44 EDT 
This is very painful. It means that one has to create the synchronization every time manually instead of just refreshing the view.
Comment 2 Remy Suen CLA 2011-09-19 19:43:07 EDT 
When a synchronize is requested again from the view, a fetch operation does not get instantiated so the view cannot be updated as there is nothing new to compare.
Comment 3 Dariusz Luksza CLA 2012-07-03 18:00:07 EDT 
As Remy mentioned the fetch operation was not executed when 'Synchronize' icon was clicked (or F5 pressed). Change #6600 [1] updates synchronize participant behavior to run fetch operation before participant is executed.

[1] https://git.eclipse.org/r/6600
Comment 4 Robin Stocker CLA 2012-07-23 10:47:05 EDT 
Dani: In bug 361784, you reported that "Synchronize Workspace fetches without notifying the user". Does that just refer to the initial synchronization?

Or in other words, do you think it's ok to fetch on refresh/F5?

(Trying to figure out the relation between these two reports.)
Comment 5 Dani Megert CLA 2012-10-09 06:28:11 EDT 
(In reply to comment #4)
> Dani: In bug 361784, you reported that "Synchronize Workspace fetches
> without notifying the user". Does that just refer to the initial
> synchronization?
> 
> Or in other words, do you think it's ok to fetch on refresh/F5?

It should simply honor the preference i.e. if fetch is enabled (default) then F5/Synchronize should also fetch before synchronizing and if it is disabled, then it should behave like it currently does.
Comment 6 Dani Megert CLA 2012-10-09 07:28:09 EDT 
(In reply to comment #3)
> As Remy mentioned the fetch operation was not executed when 'Synchronize'
> icon was clicked (or F5 pressed). Change #6600 [1] updates synchronize
> participant behavior to run fetch operation before participant is executed.
> 
> [1] https://git.eclipse.org/r/6600

Merged with http://git.eclipse.org/c/egit/egit.git/commit/?id=04635056c338db70ca7d480a758cf2dbdf02d531
Comment 7 Dani Megert CLA 2012-10-10 03:43:25 EDT 
Verified in 2.2.0.201210092123.